From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FEDDC31E5B for ; Mon, 17 Jun 2019 16:06:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 39792208C4 for ; Mon, 17 Jun 2019 16:06:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cogentembedded-com.20150623.gappssmtp.com header.i=@cogentembedded-com.20150623.gappssmtp.com header.b="GorSRaYu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726669AbfFQQGB (ORCPT ); Mon, 17 Jun 2019 12:06:01 -0400 Received: from mail-lf1-f68.google.com ([209.85.167.68]:47082 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726509AbfFQQGB (ORCPT ); Mon, 17 Jun 2019 12:06:01 -0400 Received: by mail-lf1-f68.google.com with SMTP id z15so6891334lfh.13 for ; Mon, 17 Jun 2019 09:05:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Ftr3IF6tEhAQtJEYORdg+72gK/8WB7Tuv1StM+dZuAk=; b=GorSRaYuzb+DQmhSgz3nUmepUzz51+Lyv6smpuuHnpoQIPtwZSpBVP4zk3LrUrQXlO Isd8K4u6O11izNx3bNmHdCC8GtUcTTiSGew6dvzyvns3ODFQ993EppLXwbnyOGhS81lN x0Brxfw7ipJf1iktkzM0o+LpQRAxEcHbDnn/Zlgk4vpkLCWNLWYZlOiXgM2onbNmBgQ8 DvoksYUQL0DBgWqQQnS6v4s555bHT1eDk79ZK10zrefEzd7BUxBdPMl7K8iCb5y98vFe 9IISN4PaKDRAckmOUQhTBAd+hYv9DydnF7Jlm9TYY9czpM/B8OqxcRj6tvjbcg5PV/Mc B9yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=Ftr3IF6tEhAQtJEYORdg+72gK/8WB7Tuv1StM+dZuAk=; b=DnGPaQlkeEtRP/9aAR1YKjpgZszAKUSAlG761Mv83zApXUi3QEixdt/BgzRw6RgfHX JgCtWDgsrOsWcOVzidRULgjnc9xlNYfeUTGZSDu80pzbtTngO4uf2f+FAwXnoInBIJY1 VDLBLmL44Cq7emJ9amlz4TiPQxoeetDxlLiG5QrZ99ocdwI6pi7EHNjjOyGYaYIYzPh7 u3FGG0FB0NPcUraJjo7wV8UUMcmLE1nyYHrT6kBkDlLX9MLk6BIHztyv5nB8GCcsUl1g 0TarzFY6f7lpJmaO8ES4B6oUYhHNXdG9vdzwHMk+djuN8JgkJU1vQciyXKjfTxdod0hj gEbw== X-Gm-Message-State: APjAAAVJz9YovoHisUhZVYOuyUkFU2wCp8bwLUtSVeQrr81qrdwxR1Or +gi8lOJjZsU7zv1od1pd8rFcBA== X-Google-Smtp-Source: APXvYqxy91RpuobIYehP+3aOoQHmmQtMCXRPP5GVPK8YNQWAOFzrL+2r+mJVUmXGGCJGyYDS5xdg4w== X-Received: by 2002:a19:7905:: with SMTP id u5mr55463097lfc.117.1560787559152; Mon, 17 Jun 2019 09:05:59 -0700 (PDT) Received: from wasted.cogentembedded.com ([31.173.84.129]) by smtp.gmail.com with ESMTPSA id m17sm2174140lji.16.2019.06.17.09.05.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 17 Jun 2019 09:05:58 -0700 (PDT) Subject: Re: [PATCH v4 6/8] ARM: dts: imx7ulp: add imx7ulp USBOTG1 support To: Peter Chen , "balbi@kernel.org" , "shawnguo@kernel.org" Cc: "robh+dt@kernel.org" , Fabio Estevam , "kernel@pengutronix.de" , "devicetree@vger.kernel.org" , Aisheng Dong , dl-linux-imx , "linux-arm-kernel@lists.infradead.org" , "linux-usb@vger.kernel.org" , "chunfeng.yun@mediatek.com" References: <20190614093544.11730-1-peter.chen@nxp.com> <20190614093544.11730-7-peter.chen@nxp.com> <0dbf01f9-7c5c-ce0b-4feb-378c9147f15a@cogentembedded.com> From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <7d50357c-64b4-f504-e1b8-0e4542b59d12@cogentembedded.com> Date: Mon, 17 Jun 2019 19:05:57 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-MW Content-Transfer-Encoding: 7bit Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Hello! On 06/17/2019 04:13 AM, Peter Chen wrote: [...] >>> Signed-off-by: Peter Chen >>> --- >>> arch/arm/boot/dts/imx7ulp.dtsi | 28 ++++++++++++++++++++++++++++ >>> 1 file changed, 28 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/imx7ulp.dtsi >>> b/arch/arm/boot/dts/imx7ulp.dtsi index fca6e50f37c8..5115e47715c3 >>> 100644 >>> --- a/arch/arm/boot/dts/imx7ulp.dtsi >>> +++ b/arch/arm/boot/dts/imx7ulp.dtsi >>> @@ -30,6 +30,7 @@ >>> serial1 = &lpuart5; >>> serial2 = &lpuart6; >>> serial3 = &lpuart7; >>> + usbphy0 = &usbphy1; >> >> Is that really needed? > Yes, since the driver code uses aligned id, and the controller number is from 0 at the code. > I commented it here: [1] Fair enough... >> [...] >>> @@ -133,6 +134,33 @@ >> [...] >>> + usbphy1: usbphy@0x40350000 { >> >> Name it "usb-phy@40350000" please. >> > > Would you please list binding doc for your suggestion? The DT spec v0.2, section 2.2.2: https://github.com/devicetree-org/devicetree-specification/releases/download/v0.2/devicetree-specification-v0.2.pdf > > Thanks, > Peter > > [1] https://patchwork.kernel.org/patch/10920599/ MBR, Sergei