linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejas Joglekar <Tejas.Joglekar@synopsys.com>
To: "H. Nikolaus Schaller" <hns@goldelico.com>,
	Tejas Joglekar <Tejas.Joglekar@synopsys.com>,
	Felipe Balbi <balbi@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	"Discussions about the Letux Kernel"
	<letux-kernel@openphoenux.org>,
	"kernel@pyra-handheld.com" <kernel@pyra-handheld.com>,
	Linux-OMAP <linux-omap@vger.kernel.org>
Subject: Re: [BUG]: usb: dwc3: gadget: broken on OMAP5432
Date: Wed, 8 Jan 2020 09:06:34 +0000	[thread overview]
Message-ID: <7daf64ba-7efb-e2f1-a449-f5f3791a3c8e@synopsys.com> (raw)
In-Reply-To: <703DD239-8E3B-405C-A531-FF7DEEED38DC@goldelico.com>

Hi,
On 1/8/2020 2:29 PM, H. Nikolaus Schaller wrote:
> Hi,
> I noticed that the usb ethernet gadget driver is broken since v5.5-rc2
> and 5.4.4, but only for our OMAP5 board. Our OMAP3 boards work with
> the same tree, kernel binary and user-space (Debian Stretch).
> 
> The symptom is that I can see the interface on the host PC being
> enumerated and IP addresses etc. are set up. But a ping in either
> direction fails/times out.
> 
> After inspecting diffs I found some changes in dwc3:gadget
> and indeed omap3/twl4030 uses musb and omap5 uses dwc3.
> 
> Reverting
> 
> a7f7e61270f1 ("usb: dwc3: gadget: Fix logical condition");
> 
> on v5.5-rc makes it work again.
> 
> BTW: v4.19.90 works although it includes this logical condition fix.
> So the real difference between v4.19 and v5.5 may be elsewhere in
> newer kernels and only be revealed by the patch.
> 
> If important: my setup is running with USB2 cable and speed
> only.
> 
> So please check this and other recent dwc3 patches for introducing
> a stall of communication.
> 
Another gadget driver issue was reported by Thinh after my fix, and he has submitted a patch for the same. You can refer the discussion https://patchwork.kernel.org/patch/11292087/.
Can you check if that patch works for you ?

> BR and thanks,
> Nikolaus Schaller
> 
> 

Thanks & Regards,
 Tejas Joglekar

  reply	other threads:[~2020-01-08  9:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-08  8:59 [BUG]: usb: dwc3: gadget: broken on OMAP5432 H. Nikolaus Schaller
2020-01-08  9:06 ` Tejas Joglekar [this message]
2020-01-08 14:02   ` H. Nikolaus Schaller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7daf64ba-7efb-e2f1-a449-f5f3791a3c8e@synopsys.com \
    --to=tejas.joglekar@synopsys.com \
    --cc=balbi@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hns@goldelico.com \
    --cc=kernel@pyra-handheld.com \
    --cc=letux-kernel@openphoenux.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).