From: Kevin Hilman <khilman@baylibre.com>
To: Amjad Ouled-Ameur <aouledameur@baylibre.com>,
Felipe Balbi <balbi@kernel.org>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
Jerome Brunet <jbrunet@baylibre.com>,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH 0/3] usb: meson: fix shared reset control use
Date: Mon, 30 Nov 2020 16:05:24 -0800 [thread overview]
Message-ID: <7hzh2ytmpn.fsf@baylibre.com> (raw)
In-Reply-To: <093933fc-eac5-de56-d314-a1348de348af@baylibre.com>
Amjad Ouled-Ameur <aouledameur@baylibre.com> writes:
> Hello Felipe and Kevin,
>
>
> Could you please review this patchset ?
The changes are OK with me. Please update based on Martin's
suggestions and this can be queued up by the USB maintainers.
Kevin
> Thank you in advance.
>
> On 13/11/2020 01:05, Amjad Ouled-Ameur wrote:
>
>> This patchset fixes a usb suspend warning seen on the libretech-cc by
>> using reset_control_rearm() call of the reset framework API.
>> This call allows a reset consummer to release the reset line even when
>> just triggered so that it may be triggered again by other reset
>> consummers.
>>
>> reset_control_(de)assert() calls are called, in some meson usb drivers,
>> on a shared reset line when reset_control_reset has been used. This is not
>> allowed by the reset framework.
>>
>> Finally the meson usb drivers are updated to use this new call, which
>> solves the suspend issue addressed by the previous reverted
>> commit 7a410953d1fb ("usb: dwc3: meson-g12a: fix shared reset control
>> use").
>>
>> Important:
>> Please DO NOT merge before this patch [0] is merged, it adds
>> reset_control_rearm() call to the reset framework API.
>>
>> [0] https://lore.kernel.org/lkml/20201112230043.28987-1-aouledameur@baylib
>> re.com/
>>
>> Amjad Ouled-Ameur (3):
>> phy: amlogic: phy-meson-gxl-usb2: fix shared reset controller use
>> usb: dwc3: meson-g12a: fix shared reset control use
>> phy: amlogic: meson8b-usb2: fix shared reset control use
>>
>> drivers/phy/amlogic/phy-meson-gxl-usb2.c | 5 ++++-
>> drivers/phy/amlogic/phy-meson8b-usb2.c | 4 ++++
>> drivers/usb/dwc3/dwc3-meson-g12a.c | 19 +++++++++++++------
>> 3 files changed, 21 insertions(+), 7 deletions(-)
>>
>>
> Sincerely,
> Amjad
prev parent reply other threads:[~2020-12-01 0:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 0:05 [PATCH 0/3] usb: meson: fix shared reset control use Amjad Ouled-Ameur
2020-11-13 0:05 ` [PATCH 1/3] phy: amlogic: phy-meson-gxl-usb2: fix shared reset controller use Amjad Ouled-Ameur
2020-11-14 19:13 ` Martin Blumenstingl
2020-11-17 9:16 ` Amjad Ouled-Ameur
2020-11-13 0:05 ` [PATCH 2/3] usb: dwc3: meson-g12a: fix shared reset control use Amjad Ouled-Ameur
2020-11-13 0:05 ` [PATCH 3/3] phy: amlogic: meson8b-usb2: " Amjad Ouled-Ameur
2020-11-14 19:11 ` Martin Blumenstingl
2020-11-17 9:13 ` Amjad Ouled-Ameur
2020-11-23 9:29 ` [PATCH 0/3] usb: meson: " Amjad Ouled-Ameur
2020-12-01 0:05 ` Kevin Hilman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hzh2ytmpn.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=aouledameur@baylibre.com \
--cc=balbi@kernel.org \
--cc=jbrunet@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).