From: Guenter Roeck <linux@roeck-us.net>
To: Jun Li <jun.li@nxp.com>,
"heikki.krogerus@linux.intel.com"
<heikki.krogerus@linux.intel.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH v2] usb: typec: tcpci: mask event interrupts when remove driver
Date: Sun, 19 Jan 2020 22:06:29 -0800 [thread overview]
Message-ID: <833f7fe4-37f1-5a8e-755c-4f92c467098b@roeck-us.net> (raw)
In-Reply-To: <1579499461-13076-1-git-send-email-jun.li@nxp.com>
On 1/19/20 9:55 PM, Jun Li wrote:
> This is to prevent any possible events generated while unregister
> tpcm port.
>
> Fixes: 74e656d6b0551 ("staging: typec: Type-C Port Controller Interface driver (tcpci)")
> Signed-off-by: Li Jun <jun.li@nxp.com>
> ---
> drivers/usb/typec/tcpm/tcpci.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/usb/typec/tcpm/tcpci.c b/drivers/usb/typec/tcpm/tcpci.c
> index c1f7073..fb9f2c1 100644
> --- a/drivers/usb/typec/tcpm/tcpci.c
> +++ b/drivers/usb/typec/tcpm/tcpci.c
> @@ -581,6 +581,12 @@ static int tcpci_probe(struct i2c_client *client,
> static int tcpci_remove(struct i2c_client *client)
> {
> struct tcpci_chip *chip = i2c_get_clientdata(client);
> + int err;
> +
> + /* Disable chip interrupts before unregistger port */
s/unregistger/unregistering/
Sorry, I should have noticed before.
> + err = tcpci_write16(chip->tcpci, TCPC_ALERT_MASK, 0);
> + if (err < 0)
> + return err;
>
> tcpci_unregister_port(chip->tcpci);
>
>
next prev parent reply other threads:[~2020-01-20 6:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 5:55 [PATCH v2] usb: typec: tcpci: mask event interrupts when remove driver Jun Li
2020-01-20 6:06 ` Guenter Roeck [this message]
2020-01-20 6:42 ` Jun Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=833f7fe4-37f1-5a8e-755c-4f92c467098b@roeck-us.net \
--to=linux@roeck-us.net \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jun.li@nxp.com \
--cc=linux-imx@nxp.com \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).