Linux-USB Archive on lore.kernel.org
 help / color / Atom feed
From: Tejas Joglekar <Tejas.Joglekar@synopsys.com>
To: Greg KH <greg@kroah.com>, Tejas Joglekar <Tejas.Joglekar@synopsys.com>
Cc: Felipe Balbi <balbi@kernel.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Chunfeng Yun <chunfeng.yun@mediatek.com>,
	Fredrik Noring <noring@nocrew.org>,
	"Mathias Nyman" <mathias.nyman@intel.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Raul E Rangel <rrangel@chromium.org>,
	Laurentiu Tudor <laurentiu.tudor@nxp.com>,
	"Marek Szyprowski" <m.szyprowski@samsung.com>,
	John Youn <John.Youn@synopsys.com>
Subject: Re: [RESENDING RFC PATCH 0/4] Add logic to consolidate TRBs for Synopsys xHC
Date: Fri, 27 Mar 2020 09:43:23 +0000
Message-ID: <83732263-d8f0-760c-ca62-ec697d39ae30@synopsys.com> (raw)
In-Reply-To: <20200327092826.GB1693819@kroah.com>

On 3/27/2020 2:58 PM, Greg KH wrote:
> On Fri, Mar 27, 2020 at 02:22:23PM +0530, Tejas Joglekar wrote:
>> The Synopsys xHC has an internal TRB cache of size TRB_CACHE_SIZE for
>> each endpoint. The default value for TRB_CACHE_SIZE is 16 for SS and 8
>> for HS. The controller loads and updates the TRB cache from the
>> transfer ring in system memory whenever the driver issues a start
>> transfer or update transfer command.
>>
>> For chained TRBs, the Synopsys xHC requires that the total amount of
>> bytes for all TRBs loaded in the TRB cache be greater than or equal to
>> 1 MPS. Or the chain ends within the TRB cache (with a last TRB).
>>
>> If this requirement is not met, the controller will not be able to
>> send or receive a packet and it will hang causing a driver timeout and
>> error.
>>
>> This patch set adds logic to the XHCI driver to detect and prevent this
>> from happening along with the quirk to enable this logic for Synopsys
>> HAPS platform.
>>
>> Based on Mathias's feedback on previous implementation where consolidation
>> was done in TRB cache, with this patch series the implementation is done
>> during mapping of the URB by consolidating the SG list into a temporary
>> buffer if the SG list buffer sizes within TRB_CACHE_SIZE is less than MPS.
>>
>>
>> Tejas Joglekar (4):
>>   dt-bindings: usb: Add snps,consolidate-sgl & consolidate-sgl
>>   usb: xhci: Set quirk for XHCI_CONSOLIDATE_SG_LIST
>>   usb: dwc3: Add device property consolidate-sgl
>>   usb: xhci: Use temporary buffer to consolidate SG
>>
>> Resending as 'umlaut' is not accepted by some servers in email.
> 
> Only patch 4/4 seems to have gone through :(
> 

Resent the missing patches

      reply index

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-27  8:52 Tejas Joglekar
2020-03-27  8:34 ` [RFC PATCH 1/4] dt-bindings: usb: Add snps,consolidate-sgl & consolidate-sgl Tejas Joglekar
2020-03-27  9:41   ` [RESENDING RFC " Tejas Joglekar
2020-03-27  9:54   ` Greg KH
2020-03-27 10:11     ` Tejas Joglekar
2020-03-27 10:24       ` Greg KH
2020-03-27 10:28         ` Tejas Joglekar
2020-04-05  1:45   ` Rob Herring
2020-03-27  8:35 ` [RFC PATCH 2/4] usb: xhci: Set quirk for XHCI_CONSOLIDATE_SG_LIST Tejas Joglekar
2020-03-27  9:42   ` [RESENDING RFC " Tejas Joglekar
2020-03-27  8:35 ` [RFC PATCH 3/4] usb: dwc3: Add device property consolidate-sgl Tejas Joglekar
2020-03-27  9:42   ` [RESENDING RFC " Tejas Joglekar
2020-03-27  8:53 ` [RESENDING RFC PATCH 4/4] usb: xhci: Use temporary buffer to consolidate SG Tejas Joglekar
2020-03-27  9:27   ` Greg KH
2020-03-27 10:05     ` Tejas Joglekar
2020-03-27 10:22       ` Greg KH
2020-03-27 11:25         ` Mathias Nyman
2020-03-27 15:38           ` Raul Rangel
2020-03-27  9:28 ` [RESENDING RFC PATCH 0/4] Add logic to consolidate TRBs for Synopsys xHC Greg KH
2020-03-27  9:43   ` Tejas Joglekar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83732263-d8f0-760c-ca62-ec697d39ae30@synopsys.com \
    --to=tejas.joglekar@synopsys.com \
    --cc=John.Youn@synopsys.com \
    --cc=balbi@kernel.org \
    --cc=bigeasy@linutronix.de \
    --cc=chunfeng.yun@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=greg@kroah.com \
    --cc=laurentiu.tudor@nxp.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mark.rutland@arm.com \
    --cc=mathias.nyman@intel.com \
    --cc=noring@nocrew.org \
    --cc=robh+dt@kernel.org \
    --cc=rrangel@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-USB Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-usb/0 linux-usb/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-usb linux-usb/ https://lore.kernel.org/linux-usb \
		linux-usb@vger.kernel.org
	public-inbox-index linux-usb

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-usb


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git