From: Sanjay R Mehta <sanmehta@amd.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>,
Sanjay R Mehta <Sanju.Mehta@amd.com>
Cc: andreas.noever@gmail.com, michael.jamet@intel.com,
bhelgaas@google.com, YehezkelShB@gmail.com,
Basavaraj.Natikar@amd.com, linux-usb@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH 1/4] PCI: Add AMD USB4 host router device IDs
Date: Mon, 2 Aug 2021 23:39:32 +0530 [thread overview]
Message-ID: <8578079b-76f1-b596-db3c-e02618724ba7@amd.com> (raw)
In-Reply-To: <YQgLX2CukV8oc8eW@lahna>
On 8/2/2021 8:42 PM, Mika Westerberg wrote:
> [CAUTION: External Email]
>
> On Mon, Aug 02, 2021 at 07:58:17AM -0500, Sanjay R Mehta wrote:
>> From: Sanjay R Mehta <sanju.mehta@amd.com>
>>
>> This patch enables support for AMD USB4 host router.
>>
>> Signed-off-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com>
>> Signed-off-by: Sanjay R Mehta <sanju.mehta@amd.com>
>> ---
>> drivers/thunderbolt/nhi.c | 4 ++++
>> include/linux/pci_ids.h | 2 ++
>> 2 files changed, 6 insertions(+)
>>
>> diff --git a/drivers/thunderbolt/nhi.c b/drivers/thunderbolt/nhi.c
>> index fa44332..d7d9c4b 100644
>> --- a/drivers/thunderbolt/nhi.c
>> +++ b/drivers/thunderbolt/nhi.c
>> @@ -1338,6 +1338,10 @@ static struct pci_device_id nhi_ids[] = {
>> { PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_ADL_NHI1),
>> .driver_data = (kernel_ulong_t)&icl_nhi_ops },
>>
>> + /* AMD USB4 host */
>> + { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_USB4_HIA0) },
>> + { PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_USB4_HIA1) },
>> +
>> /* Any USB4 compliant host */
>> { PCI_DEVICE_CLASS(PCI_CLASS_SERIAL_USB_USB4, ~0) },
>>
>> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
>> index 4bac183..6d50019 100644
>> --- a/include/linux/pci_ids.h
>> +++ b/include/linux/pci_ids.h
>> @@ -604,6 +604,8 @@
>> #define PCI_DEVICE_ID_AMD_HUDSON2_SMBUS 0x780b
>> #define PCI_DEVICE_ID_AMD_HUDSON2_IDE 0x780c
>> #define PCI_DEVICE_ID_AMD_KERNCZ_SMBUS 0x790b
>> +#define PCI_DEVICE_ID_AMD_USB4_HIA0 0x162e
>> +#define PCI_DEVICE_ID_AMD_USB4_HIA1 0x162f
>
> No need to add them here (and you actually should not since these IDs
> are not shared between multiple drivers, see the top level comment in
> this header).
>
> I suggest adding these to drivers/thunderbolt/nhi.h instead.
>
Thanks Mika. Agree and will add it in drivers/thunderbolt/nhi.h .
>>
>> #define PCI_VENDOR_ID_TRIDENT 0x1023
>> #define PCI_DEVICE_ID_TRIDENT_4DWAVE_DX 0x2000
>> --
>> 2.7.4
next prev parent reply other threads:[~2021-08-02 18:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-02 12:58 [PATCH 0/4] Add support for AMD USB4 and bug fixes Sanjay R Mehta
2021-08-02 12:58 ` [PATCH 1/4] PCI: Add AMD USB4 host router device IDs Sanjay R Mehta
2021-08-02 15:12 ` Mika Westerberg
2021-08-02 18:09 ` Sanjay R Mehta [this message]
2021-08-03 9:45 ` Mika Westerberg
2021-08-03 12:26 ` Sanjay R Mehta
2021-08-02 12:58 ` [PATCH 2/4] thunderbolt: Handle INTR when Disable ISR auto clear bit set Sanjay R Mehta
2021-08-02 15:22 ` Mika Westerberg
2021-08-02 18:15 ` Sanjay R Mehta
2021-08-02 12:58 ` [PATCH 3/4] thunderbolt: Fix adapter init handling during switch add Sanjay R Mehta
2021-08-02 15:26 ` Mika Westerberg
2021-08-02 18:53 ` Sanjay R Mehta
2021-08-03 9:05 ` Mika Westerberg
2021-08-03 12:29 ` Sanjay R Mehta
2021-08-02 12:58 ` [PATCH 4/4] thunderbolt: Fix port linking by checking all adapters Sanjay R Mehta
2021-08-02 15:10 ` [PATCH 0/4] Add support for AMD USB4 and bug fixes Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8578079b-76f1-b596-db3c-e02618724ba7@amd.com \
--to=sanmehta@amd.com \
--cc=Basavaraj.Natikar@amd.com \
--cc=Sanju.Mehta@amd.com \
--cc=YehezkelShB@gmail.com \
--cc=andreas.noever@gmail.com \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=michael.jamet@intel.com \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).