From: Paul Cercueil <paul@crapouillou.net>
To: "kernel test robot" <lkp@intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Christian König" <christian.koenig@amd.com>
Cc: oe-kbuild-all@lists.linux.dev, michael.hennerich@analog.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, nuno.sa@analog.com,
linaro-mm-sig@lists.linaro.org, linux-media@vger.kernel.org
Subject: Re: [PATCH 2/2] usb: gadget: functionfs: Add DMABUF import interface
Date: Tue, 14 Mar 2023 14:45:19 +0100 [thread overview]
Message-ID: <861288e8c685eb9cbbf9f71cd031e7015de3aced.camel@crapouillou.net> (raw)
In-Reply-To: <202303142140.ZQsw4C4V-lkp@intel.com>
Le mardi 14 mars 2023 à 21:41 +0800, kernel test robot a écrit :
> Hi Paul,
>
> I love your patch! Perhaps something to improve:
>
> [auto build test WARNING on usb/usb-testing]
> [also build test WARNING on usb/usb-next usb/usb-linus linus/master
> v6.3-rc2 next-20230314]
> [If your patch is applied to the wrong git tree, kindly drop us a
> note.
> And when submitting patch, we suggest to use '--base' as documented
> in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url:
> https://github.com/intel-lab-lkp/linux/commits/Paul-Cercueil/usb-gadget-Support-already-mapped-DMA-SGs/20230314-185522
> base:
> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-
> testing
> patch link:
> https://lore.kernel.org/r/20230314105257.17345-3-paul%40crapouillou.net
> patch subject: [PATCH 2/2] usb: gadget: functionfs: Add DMABUF import
> interface
> config: m68k-allyesconfig
> (https://download.01.org/0day-ci/archive/20230314/202303142140.ZQsw4C
> 4V-lkp@intel.com/config)
> compiler: m68k-linux-gcc (GCC) 12.1.0
> reproduce (this is a W=1 build):
> wget
> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
> -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> #
> https://github.com/intel-lab-lkp/linux/commit/4ee364ed5d112c4550344fd037f4e1ef7cc41878
> git remote add linux-review
> https://github.com/intel-lab-lkp/linux
> git fetch --no-tags linux-review Paul-Cercueil/usb-gadget-
> Support-already-mapped-DMA-SGs/20230314-185522
> git checkout 4ee364ed5d112c4550344fd037f4e1ef7cc41878
> # save the config file
> mkdir build_dir && cp config build_dir/.config
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0
> make.cross W=1 O=build_dir ARCH=m68k olddefconfig
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0
> make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/usb/
>
> If you fix the issue, kindly add following tag where applicable
> > Reported-by: kernel test robot <lkp@intel.com>
> > Link:
> > https://lore.kernel.org/oe-kbuild-all/202303142140.ZQsw4C4V-lkp@intel.com/
>
> All warnings (new ones prefixed by >>):
>
> > > drivers/usb/gadget/function/f_fs.c:1401:5: warning: no previous
> > > prototype for 'ffs_dma_resv_lock' [-Wmissing-prototypes]
> 1401 | int ffs_dma_resv_lock(struct dma_buf *dmabuf, bool
> nonblock)
> | ^~~~~~~~~~~~~~~~~
Indeed, missing a "static" here. Thank you Robot.
Cheers,
-Paul
>
>
> vim +/ffs_dma_resv_lock +1401 drivers/usb/gadget/function/f_fs.c
>
> 1400
> > 1401 int ffs_dma_resv_lock(struct dma_buf *dmabuf, bool
> > nonblock)
> 1402 {
> 1403 int ret;
> 1404
> 1405 ret = dma_resv_lock_interruptible(dmabuf->resv,
> NULL);
> 1406 if (ret) {
> 1407 if (ret != -EDEADLK)
> 1408 goto out;
> 1409 if (nonblock) {
> 1410 ret = -EBUSY;
> 1411 goto out;
> 1412 }
> 1413
> 1414 ret =
> dma_resv_lock_slow_interruptible(dmabuf->resv, NULL);
> 1415 }
> 1416
> 1417 out:
> 1418 return ret;
> 1419 }
> 1420
>
next prev parent reply other threads:[~2023-03-14 13:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 10:52 [PATCH 0/2] usb: gadget: functionfs: DMABUF import interface Paul Cercueil
2023-03-14 10:52 ` [PATCH 1/2] usb: gadget: Support already-mapped DMA SGs Paul Cercueil
2023-03-14 10:52 ` [PATCH 2/2] usb: gadget: functionfs: Add DMABUF import interface Paul Cercueil
2023-03-14 11:59 ` Christian König
2023-03-19 11:54 ` Paul Cercueil
2023-03-14 13:41 ` kernel test robot
2023-03-14 13:45 ` Paul Cercueil [this message]
2023-03-15 4:10 ` kernel test robot
2023-03-15 8:36 ` kernel test robot
2023-03-15 21:36 ` kernel test robot
2023-03-14 12:01 ` [PATCH 0/2] usb: gadget: functionfs: " Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=861288e8c685eb9cbbf9f71cd031e7015de3aced.camel@crapouillou.net \
--to=paul@crapouillou.net \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lkp@intel.com \
--cc=michael.hennerich@analog.com \
--cc=nuno.sa@analog.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).