From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CA85CA9EA0 for ; Tue, 22 Oct 2019 06:11:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 71DEC21872 for ; Tue, 22 Oct 2019 06:11:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571724688; bh=TB3duWQd78jFW1Z+mqPYrMFMpJSQtlpWnblKJqe93E4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:List-ID:From; b=0tfdylHPn4MUoJoUBvLs3bJKAHOuHTxv1B0eKnGdEMnDZimfLX4XGuLXDFfPC5xbW WdYQH6QgHeYipMzOUizQkqKjl3C+0HwM2HxR4K7nKmkcqugtRvQq3vIJkm9q874ZbI Anpd62q1ylGrgZZJvehFE14oIqE6moO3BwfgFOZA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731093AbfJVGLZ (ORCPT ); Tue, 22 Oct 2019 02:11:25 -0400 Received: from mga18.intel.com ([134.134.136.126]:52133 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726082AbfJVGLZ (ORCPT ); Tue, 22 Oct 2019 02:11:25 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Oct 2019 23:11:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,326,1566889200"; d="scan'208";a="196337878" Received: from pipin.fi.intel.com (HELO pipin) ([10.237.72.175]) by fmsmga008.fm.intel.com with ESMTP; 21 Oct 2019 23:11:21 -0700 From: Felipe Balbi To: Michal Simek , Saurav Girepunje , gregkh@linuxfoundation.org, michal.simek@xilinx.com, swboyd@chromium.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: saurav.girepunje@hotmail.com Subject: Re: [PATCH] usb: gadget: udc: Fix assignment of 0/1 to bool variables In-Reply-To: References: <20191007181527.GA6816@saurav> Date: Tue, 22 Oct 2019 09:11:21 +0300 Message-ID: <8736fl48dy.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Hi, Michal Simek writes: >> @@ -1952,9 +1952,9 @@ static void xudc_nonctrl_ep_handler(struct xusb_udc *udc, u8 epnum, >> ep = &udc->ep[epnum]; >> /* Process the End point interrupts.*/ >> if (intrstatus & (XUSB_STATUS_EP0_BUFF1_COMP_MASK << epnum)) >> - ep->buffer0ready = 0; >> + ep->buffer0ready = false; >> if (intrstatus & (XUSB_STATUS_EP0_BUFF2_COMP_MASK << epnum)) >> - ep->buffer1ready = 0; >> + ep->buffer1ready = false; >> >> if (list_empty(&ep->queue)) >> return; >> > > Acked-by: Michal Simek I don't have the original patch, sorry. Care to resend with Acks? -- balbi