Linux-USB Archive on
 help / color / Atom feed
From: Felipe Balbi <>
To: EJ Hsu <>,
	"linux-usb\" <>
Subject: RE: [PATCH] usb: gadget: fix wrong endpoint desc
Date: Wed, 04 Dec 2019 14:15:41 +0200
Message-ID: <> (raw)
In-Reply-To: <>

[-- Attachment #1: Type: text/plain, Size: 778 bytes --]


EJ Hsu <> writes:
> Felipe Balb writes:
>>EJ Hsu <> writes:
>>> Gadget driver should always use config_ep_by_speed() to initialize 
>>> usb_ep struct according to usb device's operating speed. Otherwise, 
>>> usb_ep struct may be wrong if usb devcie's operating speed is changed.
>>your commit log doesn't match the patch body. What gives?
> The key point in this patch is that we want to make sure the desc pointer in
> usb_ep struct will be set to NULL when gadget is disconnected. This will force
> it to call config_ep_by_speed() to correctly initialize usb_ep struct based on 
> the new operating speed when gadget is re-connected later.

this would be a commit log that matches the implementation ;-)


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

      reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-03 10:46 EJ Hsu
2019-12-03 12:31 ` Felipe Balbi
2019-12-04  2:58   ` EJ Hsu
2019-12-04 12:15     ` Felipe Balbi [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-USB Archive on

Archives are clonable:
	git clone --mirror linux-usb/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-usb linux-usb/ \
	public-inbox-index linux-usb

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone