From: Felipe Balbi <balbi@kernel.org>
To: EJ Hsu <ejh@nvidia.com>,
"linux-usb\@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: RE: [PATCH] usb: gadget: fix wrong endpoint desc
Date: Wed, 04 Dec 2019 14:15:41 +0200 [thread overview]
Message-ID: <875ziwffrm.fsf@gmail.com> (raw)
In-Reply-To: <MN2PR12MB4126C72DAA5292DA99477FAACF5D0@MN2PR12MB4126.namprd12.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 778 bytes --]
Hi,
EJ Hsu <ejh@nvidia.com> writes:
> Felipe Balb writes:
>>EJ Hsu <ejh@nvidia.com> writes:
>>> Gadget driver should always use config_ep_by_speed() to initialize
>>> usb_ep struct according to usb device's operating speed. Otherwise,
>>> usb_ep struct may be wrong if usb devcie's operating speed is changed.
>>
>>your commit log doesn't match the patch body. What gives?
>
> The key point in this patch is that we want to make sure the desc pointer in
> usb_ep struct will be set to NULL when gadget is disconnected. This will force
> it to call config_ep_by_speed() to correctly initialize usb_ep struct based on
> the new operating speed when gadget is re-connected later.
this would be a commit log that matches the implementation ;-)
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
prev parent reply other threads:[~2019-12-04 12:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 10:46 [PATCH] usb: gadget: fix wrong endpoint desc EJ Hsu
2019-12-03 12:31 ` Felipe Balbi
2019-12-04 2:58 ` EJ Hsu
2019-12-04 12:15 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875ziwffrm.fsf@gmail.com \
--to=balbi@kernel.org \
--cc=ejh@nvidia.com \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).