From: Felipe Balbi <balbi@kernel.org>
To: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Wesley Cheng <wcheng@codeaurora.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"agross@kernel.org" <agross@kernel.org>,
"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"frowand.list@gmail.com" <frowand.list@gmail.com>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"jackp@codeaurora.org" <jackp@codeaurora.org>
Subject: Re: [PATCH v14 3/6] usb: dwc3: Resize TX FIFOs to meet EP bursting requirements
Date: Wed, 14 Jul 2021 09:40:13 +0300 [thread overview]
Message-ID: <877dhtz9de.fsf@kernel.org> (raw)
In-Reply-To: <e08dac42-e999-fd97-21ab-34cd70429f03@synopsys.com>
[-- Attachment #1: Type: text/plain, Size: 3841 bytes --]
Hi,
Thinh Nguyen <Thinh.Nguyen@synopsys.com> writes:
>> Thinh Nguyen <Thinh.Nguyen@synopsys.com> writes:
>>> Wesley Cheng wrote:
>>>> Some devices have USB compositions which may require multiple endpoints
>>>> that support EP bursting. HW defined TX FIFO sizes may not always be
>>>> sufficient for these compositions. By utilizing flexible TX FIFO
>>>> allocation, this allows for endpoints to request the required FIFO depth to
>>>> achieve higher bandwidth. With some higher bMaxBurst configurations, using
>>>> a larger TX FIFO size results in better TX throughput.
>>>>
>>>> By introducing the check_config() callback, the resizing logic can fetch
>>>> the maximum number of endpoints used in the USB composition (can contain
>>>> multiple configurations), which helps ensure that the resizing logic can
>>>> fulfill the configuration(s), or return an error to the gadget layer
>>>> otherwise during bind time.
>>>>
>>>> Signed-off-by: Wesley Cheng <wcheng@codeaurora.org>
>>>> ---
>>>> drivers/usb/dwc3/core.c | 15 +++
>>>> drivers/usb/dwc3/core.h | 16 ++++
>>>> drivers/usb/dwc3/ep0.c | 2 +
>>>> drivers/usb/dwc3/gadget.c | 232 ++++++++++++++++++++++++++++++++++++++++++++++
>>>> 4 files changed, 265 insertions(+)
>>>>
>>>> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
>>>> index ba74ad7..b194aecd 100644
>>>> --- a/drivers/usb/dwc3/core.c
>>>> +++ b/drivers/usb/dwc3/core.c
>>>> @@ -1267,6 +1267,7 @@ static void dwc3_get_properties(struct dwc3 *dwc)
>>>> u8 rx_max_burst_prd;
>>>> u8 tx_thr_num_pkt_prd;
>>>> u8 tx_max_burst_prd;
>>>> + u8 tx_fifo_resize_max_num;
>>>> const char *usb_psy_name;
>>>> int ret;
>>>>
>>>> @@ -1282,6 +1283,13 @@ static void dwc3_get_properties(struct dwc3 *dwc)
>>>> */
>>>> hird_threshold = 12;
>>>>
>>>> + /*
>>>> + * default to a TXFIFO size large enough to fit 6 max packets. This
>>>> + * allows for systems with larger bus latencies to have some headroom
>>>> + * for endpoints that have a large bMaxBurst value.
>>>> + */
>>>> + tx_fifo_resize_max_num = 6;
>>>> +
>>>> dwc->maximum_speed = usb_get_maximum_speed(dev);
>>>> dwc->max_ssp_rate = usb_get_maximum_ssp_rate(dev);
>>>> dwc->dr_mode = usb_get_dr_mode(dev);
>>>> @@ -1325,6 +1333,11 @@ static void dwc3_get_properties(struct dwc3 *dwc)
>>>> &tx_thr_num_pkt_prd);
>>>> device_property_read_u8(dev, "snps,tx-max-burst-prd",
>>>> &tx_max_burst_prd);
>>>> + dwc->do_fifo_resize = device_property_read_bool(dev,
>>>> + "tx-fifo-resize");
>>>> + if (dwc->do_fifo_resize)
>>>> + device_property_read_u8(dev, "tx-fifo-max-num",
>>>> + &tx_fifo_resize_max_num);
>>>
>>> Why is this check here? The dwc->tx_fifo_resize_max_num should store
>>> whatever property the user sets. Whether the driver wants to use this
>>
>> Ack!
>>
>>> property should depend on "dwc->do_fifo_resize". Also why don't we have
>>> "snps," prefix to be consistent with the other properties?
>>
>> Ack!
>>
>>> Can we enforce to a single property? If the designer wants to enable
>>> this feature, he/she can to provide the tx-fifo-max-num. This would
>>> simplify the driver a bit. Since this is to optimize for performance,
>>> the user should know/want/test the specific value if they want to set
>>> for their setup and not hoping that the default setting not break their
>>> setup. So we can remove the "do_fifo_resize" property and just check
>>> whether tx_fifo_resize_max_num is set.
>>
>> Ack!
>>
>> All very valid points :-)
>>
>
> Looks like this series already landed in Greg's testing branch. Not sure
> how we usually handle this to address some of our concerns. Add fix
> patches on top of Greg's testing branch?
yup, no choice anymore :-(
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 511 bytes --]
next prev parent reply other threads:[~2021-07-14 6:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-10 9:13 [PATCH v14 0/6] Re-introduce TX FIFO resize for larger EP bursting Wesley Cheng
2021-07-10 9:13 ` [PATCH v14 1/6] usb: gadget: udc: core: Introduce check_config to verify USB configuration Wesley Cheng
2021-07-10 9:13 ` [PATCH v14 2/6] usb: gadget: configfs: Check USB configuration before adding Wesley Cheng
2021-07-10 9:13 ` [PATCH v14 3/6] usb: dwc3: Resize TX FIFOs to meet EP bursting requirements Wesley Cheng
2021-07-12 23:38 ` Thinh Nguyen
2021-07-13 8:39 ` Felipe Balbi
2021-07-14 2:58 ` Thinh Nguyen
2021-07-14 3:10 ` Thinh Nguyen
2021-07-14 6:40 ` Felipe Balbi [this message]
2021-07-14 6:52 ` gregkh
2021-07-14 7:30 ` Wesley Cheng
2021-07-20 11:41 ` gregkh
2021-07-21 6:23 ` Wesley Cheng
2021-07-14 6:51 ` gregkh
2021-07-14 2:59 ` Thinh Nguyen
2021-07-10 9:13 ` [PATCH v14 4/6] of: Add stub for of_add_property() Wesley Cheng
2021-07-10 9:13 ` [PATCH v14 5/6] usb: dwc3: dwc3-qcom: Enable tx-fifo-resize property by default Wesley Cheng
2021-07-10 9:13 ` [PATCH v14 6/6] dt-bindings: usb: dwc3: Update dwc3 TX fifo properties Wesley Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dhtz9de.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jackp@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=wcheng@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).