archive mirror
 help / color / mirror / Atom feed
From: Felipe Balbi <>
To: Sergey Shtylyov <>
	Greg Kroah-Hartman <>
Subject: Re: [PATCH v3 2/2] usb: phy: tahvo: add IRQ check
Date: Sat, 14 Aug 2021 14:28:27 +0300	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Sergey Shtylyov <> writes:

> The driver neglects to check the result of platform_get_irq()'s call and
> blithely passes the negative error codes to request_threaded_irq() (which
> takes *unsigned* IRQ #), causing it to fail with -EINVAL, overriding an
> original error code.  Stop calling request_threaded_irq() with the invalid
> IRQ #s.
> Fixes: 9ba96ae5074c ("usb: omap1: Tahvo USB transceiver driver")
> Signed-off-by: Sergey Shtylyov <>

Acked-by: Felipe Balbi <>


  reply	other threads:[~2021-08-14 11:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-13 20:23 [PATCH v3 0/2] Stop calling request_irq(), etc. with invalid IRQs in the USB drivers` Sergey Shtylyov
2021-08-13 20:30 ` [PATCH v3 1/2] usb: host: ohci-tmio: add IRQ check Sergey Shtylyov
2021-08-14  1:45   ` Alan Stern
2021-08-13 20:32 ` [PATCH v3 2/2] usb: phy: tahvo: " Sergey Shtylyov
2021-08-14 11:28   ` Felipe Balbi [this message]
2021-08-14  6:39 ` [PATCH v3 0/2] Stop calling request_irq(), etc. with invalid IRQs in the USB drivers` Greg Kroah-Hartman
2021-08-14 11:59   ` Sergey Shtylyov
2021-08-14 13:34     ` Greg Kroah-Hartman
2021-08-14 18:16       ` Sergey Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).