From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A29BC4320A for ; Thu, 26 Aug 2021 10:50:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7F2ED6108F for ; Thu, 26 Aug 2021 10:50:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241698AbhHZKvV (ORCPT ); Thu, 26 Aug 2021 06:51:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:51640 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234327AbhHZKvV (ORCPT ); Thu, 26 Aug 2021 06:51:21 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E19E6606A5; Thu, 26 Aug 2021 10:50:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629975034; bh=09c1tjsSoixex+O8jJiLxYsaqmIjwNXlEeH57q+wSKc=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=emO/LkNmsXwHX5hq2482q5F0m3lzEBYK0pcn/gIzx9OBMS85D6rNFOLCyuOUEtRjj drl6KaTXQBWVwcJwZ1WErXWbJYazv/h4zATFt2q/7p1/Mf7vN9hVAhr4B2hIi4FnIh P7K9b9e+XpsdxD9ci7LGQa/+v4wpIP4x4YRjnNgAlROUekKaAcNFruUa8adV3YLqzQ d2r/WE9t9NhoHoqnTmGmJdsgps4K9k7jthRX5psJIP+2v/4sEw8wMUPvlVInQGPR2C XZWTUh4KwJqzaC/yU+sKErvZ2Nm9hywqFi4GcCczEKMEZZNn0GxwAVXpMzJ9oQ7T4I HrfSAEPm/Ud/g== References: <87bl63yqq8.fsf@kernel.org> User-agent: mu4e 1.6.4; emacs 27.2 From: Felipe Balbi To: Sandeep Maheswaram Cc: Greg Kroah-Hartman , Mathias Nyman , linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Pratham Pratap , Jack Pham , Stephen Boyd , Matthias Kaehlcke , Doug Anderson Subject: Re: Regarding usb dwc3 core shutdown callback Date: Thu, 26 Aug 2021 13:43:11 +0300 In-reply-to: Message-ID: <87eeaga39m.fsf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Hi, Sandeep Maheswaram writes: >> (why isn't this email plain/text? Content Type was set to multipart >> alternative, please configure your email client correctly :-) >> >> While at that, also make sure to break lines at 80-columns) >> >> Sandeep Maheswaram writes: >>> Hi, >>> >>> Earlier I have posted the patch for usb dwc3 core shutdown callback >>> >>> https://lore.kernel.org/linux-arm-msm/1618380209-20114-1-git-send-email-sanm@codeaurora.org/ >>> >>> and it was reverted due to issues. >> Right, as should be expected when we find regressions >> >>> https://lore.kernel.org/linux-usb/20210603151742.298243-1-alexandru.elisei@arm.com/ >>> >>> As we already have shutdown callback in xhci plat driver where we halt >>> the controller, so there will be no transactions with usb devices. >>> >>> https://lore.kernel.org/linux-usb/20200306092328.41253-1-ran.wang_1@nxp.com/ >>> >>> So I think dwc3 core shutdown may not be required at least when we are >>> using host mode. Let me know your opinion about this. >> If that's the case, then sure. Please validate the condition, though, >> and kindly report back on your findings > > I have enabled couple of logs in shutdown path and see no URBs > enqueued after xhci shut down. > > Hope this is enough for validation . Please suggest if anything more I > could do. how about writing a little script to kexec into another kernel for a few hundred iterations and make sure things still work after all that? -- balbi