Re: [PATCH 2/2] usb: dwc3: gadget: Rename EOPF event macros to Suspend

[Felipe Balbi <balbi@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1161 bytes --]


Hi,

Jack Pham <jackp@codeaurora.org> writes:
> The device event corresponding to End of Periodic Frame is only
> found on older IP revisions (2.10a and prior, according to a

you're reading databook for dwc3.1, right? Remember the original support
for the driver was on dwc3. This was always called EOPF back then. We
should maintain the name.

> cursory SNPS databook search).  On revisions 2.30a and newer,
> including DWC3.1, the same event value and corresponding DEVTEN
> bit were repurposed to indicate that the link has gone into
> suspend state (U3 or L2/L1).
>
> EOPF events had never been enabled before in this driver, and
> going forward we expect current and future DWC3-based devices
> won't likely to be using such old DWC3 IP revisions either.

We still have original omap5 devices, running on revision 1.73a
around. They'll remain supported for the time being.

> Hence rather than keeping the deprecated EOPF macro names let's
> rename them to indicate their usage for suspend events.

what do we gain from this change? I mean, in practice, what changes?
nothing realy, so why should we apply this?

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]