From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: Rick Tseng <rtseng@nvidia.com>,
Mathias Nyman <mathias.nyman@linux.intel.com>,
Oliver Neukum <oneukum@suse.com>,
"mathias.nyman\@intel.com" <mathias.nyman@intel.com>,
"gregkh\@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "linux-usb\@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: RE: [PATCH] xhci: wait CNR when doing xhci resume
Date: Tue, 13 Aug 2019 15:36:06 +0300 [thread overview]
Message-ID: <87ef1pz1hl.fsf@gmail.com> (raw)
In-Reply-To: <MN2PR12MB3215AA4B411231FC2D67E81FB1D20@MN2PR12MB3215.namprd12.prod.outlook.com>
(no top-posting, please)
Hi,
Rick Tseng <rtseng@nvidia.com> writes:
> Hi Mathias,
>
> Thanks for suggestion.
> The reason I do not use xhci_handshake() is we get build fail when configuring below as module:
> USB_XHCI_HCD = m
> USB_XHCI_PCI = m
>
> Fail message as below:
> ERROR: "xhci_handshake" [drivers/usb/host/xhci-pci.ko] undefined!
>
> So I write my own function to check CNR.
yeah, move that code to xhci_suspend(). It's valid for any XHCI host.
--
balbi
next prev parent reply other threads:[~2019-08-13 12:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 7:24 [PATCH] xhci: wait CNR when doing xhci resume Rick Tseng
2019-08-12 8:12 ` Felipe Balbi
2019-08-12 8:19 ` Oliver Neukum
2019-08-13 10:39 ` Mathias Nyman
2019-08-13 12:33 ` Rick Tseng
2019-08-13 12:36 ` Felipe Balbi [this message]
2019-08-13 13:12 ` Mathias Nyman
2019-08-12 13:39 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ef1pz1hl.fsf@gmail.com \
--to=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=mathias.nyman@linux.intel.com \
--cc=oneukum@suse.com \
--cc=rtseng@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).