From: Felipe Balbi <balbi@kernel.org>
To: "Ardelean\, Alexandru" <alexandru.Ardelean@analog.com>,
"m.olbrich\@pengutronix.de" <m.olbrich@pengutronix.de>
Cc: "gregkh\@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-usb\@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"bigeasy\@linutronix.de" <bigeasy@linutronix.de>,
"lars\@metafoo.de" <lars@metafoo.de>
Subject: Re: [PATCH] usb: dwc3: gadget: Handle dequeuing of non queued URB gracefully
Date: Thu, 16 Jan 2020 15:05:54 +0200 [thread overview]
Message-ID: <87ftgf5z65.fsf@kernel.org> (raw)
In-Reply-To: <9d6ec804e3f1f462e5c6a43d19c83ff3493e3727.camel@analog.com>
[-- Attachment #1: Type: text/plain, Size: 1386 bytes --]
Hi,
"Ardelean, Alexandru" <alexandru.Ardelean@analog.com> writes:
> On Tue, 2019-11-12 at 15:41 +0100, Michael Olbrich wrote:
>> [External]
>>
>> On Wed, Nov 06, 2019 at 04:45:53PM +0200, Alexandru Ardelean wrote:
>> > From: Lars-Peter Clausen <lars@metafoo.de>
>> >
>> > Trying to dequeue and URB that is currently not queued should be a no-
>> > op
>> > and be handled gracefully.
>> >
>> > Use the list field of the URB to indicate whether it is queued or not
>> > by
>> > setting it to the empty list when it is not queued.
>> >
>> > Handling this gracefully allows for race condition free synchronization
>> > between the complete callback being called to to a completed transfer
>> > and
>> > trying to call usb_ep_dequeue() at the same time.
>> >
>> > Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
>> > Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
>>
>> Thanks, no more "dwc3 fe200000.usb: request 00000000cdd42e4a was not
>> queued
>> to ep2in" messages with this patch applied.
>>
>> Tested-by: Michael Olbrich <m.olbrich@pengutronix.de>
>>
>
> I thought I replied here, but I guess I never hit the Send button.
> Many thanks @Michael for testing this.
>
> I'd also use the opportunity to make this a patch-ping message.
https://lore.kernel.org/linux-usb/875zhd6pw0.fsf@kernel.org/T/#u
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2020-01-16 13:05 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 14:45 [PATCH] usb: dwc3: gadget: Handle dequeuing of non queued URB gracefully Alexandru Ardelean
2019-11-12 14:41 ` Michael Olbrich
2020-01-16 11:12 ` Ardelean, Alexandru
2020-01-16 13:05 ` Felipe Balbi [this message]
2020-01-16 13:24 ` [PATCH][RESEND] " Alexandru Ardelean
2020-01-30 12:02 ` Felipe Balbi
2020-03-10 13:22 ` Ardelean, Alexandru
2020-03-10 13:45 ` Lars-Peter Clausen
2020-03-10 14:07 ` Lars-Peter Clausen
2020-03-27 8:43 ` [PATCH] usb: dwc3: gadget: don't dequeue requests on already disabled endpoints Michael Grzeschik
2020-03-27 8:53 ` Sergei Shtylyov
2020-03-27 11:15 ` Andy Shevchenko
2020-03-27 9:14 ` Lars-Peter Clausen
2020-03-27 10:43 ` Michael Grzeschik
2020-03-27 10:55 ` Lars-Peter Clausen
2020-03-28 8:27 ` Felipe Balbi
2020-03-29 19:02 ` Michael Grzeschik
2020-03-30 7:18 ` Felipe Balbi
2020-03-30 8:25 ` Michael Grzeschik
2020-03-30 10:06 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftgf5z65.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=alexandru.Ardelean@analog.com \
--cc=bigeasy@linutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.olbrich@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).