Re: [PATCH v4 3/9] usb: dwc3: Increase timeout for CmdAct cleared by device controller

From: Felipe Balbi <balbi@kernel.org>
To: Jun Li <lijun.kernel@gmail.com>
Cc: John Stultz <john.stultz@linaro.org>,
	lkml <linux-kernel@vger.kernel.org>,
	Yu Chen <chenyu56@huawei.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	ShuFan Lee <shufan_lee@richtek.com>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Chunfeng Yun <chunfeng.yun@mediatek.com>,
	Hans de Goede <hdegoede@redhat.com>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	Valentin Schneider <valentin.schneider@arm.com>,
	Jack Pham <jackp@codeaurora.org>,
	Linux USB List <linux-usb@vger.kernel.org>,
	"open list\:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	peter.chen@nxp.com, Li Jun <jun.li@nxp.com>,
	Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Subject: Re: [PATCH v4 3/9] usb: dwc3: Increase timeout for CmdAct cleared by device controller
Date: Fri, 15 May 2020 12:31:07 +0300	[thread overview]
Message-ID: <87imgx35pg.fsf@kernel.org> (raw)
In-Reply-To: <CAKgpwJXfWv5=MDqBCADhe2iXf6eiP0GQ13Bwo9fkuU5kGO7dsw@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1204 bytes --]

Hi,

Jun Li <lijun.kernel@gmail.com> writes:
>> @@ -397,12 +407,18 @@ int dwc3_send_gadget_ep_cmd(struct dwc3_ep *dep, unsigned cmd,
>>                         dwc3_gadget_ep_get_transfer_index(dep);
>>         }
>>
>> -       if (saved_config) {
>> +       if (saved_hs_config) {
>>                 reg = dwc3_readl(dwc->regs, DWC3_GUSB2PHYCFG(0));
>> -               reg |= saved_config;
>> +               reg |= saved_hs_config;
>>                 dwc3_writel(dwc->regs, DWC3_GUSB2PHYCFG(0), reg);
>>         }
>>
>> +       if (saved_ss_config) {
>> +               reg = dwc3_readl(dwc->regs, DWC3_GUSB3PIPECTL(0));
>> +               reg |= saved_ss_config;
>> +               dwc3_writel(dwc->regs, DWC3_GUSB3PIPECTL(0), reg);
>> +       }
>> +
>>         return ret;
>>  }
>
> Unfortunately this way can't work, once the SS PHY enters P3, disable
> suspend_en can't force SS PHY exit P3, unless do this at the very beginning
> to prevent SS PHY entering P3(e.g. add "snps,dis_u3_susphy_quirk" for test).

It sounds like you have a quirky PHY. If that's the case, then you
probably need to use the flag you mentioned above. Please verify with
that.

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]