From: Felipe Balbi <balbi@kernel.org>
To: "周琰杰 (Zhou Yanjie)" <zhouyanjie@wanyeetech.com>,
gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
zhenwenjin@gmail.com, sernia.zhou@foxmail.com,
yanfei.li@ingenic.com, rick.tyliu@ingenic.com,
aric.pzqi@ingenic.com, dongsheng.qiu@ingenic.com
Subject: Re: [PATCH 1/1] USB: PHY: JZ4770: Fix static checker warning.
Date: Thu, 27 Aug 2020 16:06:07 +0300 [thread overview]
Message-ID: <87mu2gi6gw.fsf@kernel.org> (raw)
In-Reply-To: <20200825081654.18186-2-zhouyanjie@wanyeetech.com>
[-- Attachment #1: Type: text/plain, Size: 713 bytes --]
周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com> writes:
> The commit 2a6c0b82e651 ("USB: PHY: JZ4770: Add support for new
> Ingenic SoCs.") introduced the initialization function for different
> chips, but left the relevant code involved in the resetting process
> in the original function, resulting in uninitialized variable calls.
>
> Fixes: 2a6c0b82e651 ("USB: PHY: JZ4770: Add support for new
> Ingenic SoCs.").
These two lines here, they should be one line :-)
For the Fixes: line, you shouldn't worry about the 72-char limit. Also,
when resending, don't add a blank line between Fixes and Signed-off-by
and since this is a bug fix, it seems like Cc: stable is in order.
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 857 bytes --]
next prev parent reply other threads:[~2020-08-27 14:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-25 8:16 [PATCH 0/1] Fix static checker warning 周琰杰 (Zhou Yanjie)
2020-08-25 8:16 ` [PATCH 1/1] USB: PHY: JZ4770: " 周琰杰 (Zhou Yanjie)
2020-08-27 13:06 ` Felipe Balbi [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-07-28 17:02 [PATCH 0/1] " 周琰杰 (Zhou Yanjie)
2020-07-28 17:02 ` [PATCH 1/1] USB: PHY: JZ4770: " 周琰杰 (Zhou Yanjie)
2020-07-28 17:26 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mu2gi6gw.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=aric.pzqi@ingenic.com \
--cc=dongsheng.qiu@ingenic.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rick.tyliu@ingenic.com \
--cc=sernia.zhou@foxmail.com \
--cc=yanfei.li@ingenic.com \
--cc=zhenwenjin@gmail.com \
--cc=zhouyanjie@wanyeetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).