From: Felipe Balbi <balbi@kernel.org>
To: Jun Li <jun.li@nxp.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
"thunder.leizhen@huawei.com" <thunder.leizhen@huawei.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: RE: [PATCH] usb: dwc3: imx8mp: detect dwc3 core node via compatible string
Date: Tue, 11 May 2021 12:26:47 +0300 [thread overview]
Message-ID: <87o8dhfwo8.fsf@kernel.org> (raw)
In-Reply-To: <VI1PR04MB5935DE5731476311DE94009A89539@VI1PR04MB5935.eurprd04.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 1081 bytes --]
Hi,
Jun Li <jun.li@nxp.com> writes:
>> > > > Good suggestion, but if extcon notifier listener can't work for
>> > > > me, my understanding is this *teach* in glue layer driver still
>> > > > need access
>> > > > dwc3 core instance struct, right?
>> > >
>> > > for now, maybe. But it may be better to implement a notifier method
>> > > in role switch class.
>> >
>> > I am not sure if introduce notifier in role switch class is a good
>> > idea, I had the impression extcon is not encouraged to use if possible.
>>
>> I'm not against role switch notifiers. They were proposed before already
>> couple of years ago, but at that time there just were no users them notifier,
>> so the patch was just dropped from the series [1].
>> But I don't think anybody was against the idea. Please feel free to add them
>> to the class if you have use for them.
>
> So I had the incorrect impression.
>
> Yes, that's the Felipe was referring to, I think.
>
> I will pick up [1] and improve my driver as Felipe suggested.
sounds great, thahnks Li Jun
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 511 bytes --]
next prev parent reply other threads:[~2021-05-11 9:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-30 6:57 [PATCH] usb: dwc3: imx8mp: detect dwc3 core node via compatible string Li Jun
2021-04-30 8:24 ` Felipe Balbi
2021-04-30 9:38 ` Jun Li
2021-04-30 10:00 ` Felipe Balbi
2021-05-06 11:28 ` Jun Li
2021-05-06 14:31 ` Felipe Balbi
2021-05-07 7:31 ` Jun Li
2021-05-11 7:59 ` Heikki Krogerus
2021-05-11 9:23 ` Jun Li
2021-05-11 9:26 ` Felipe Balbi [this message]
2021-08-02 5:29 ` Jun Li
2021-08-02 7:49 ` Felipe Balbi
2021-08-02 10:43 ` Jun Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8dhfwo8.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jun.li@nxp.com \
--cc=linux-imx@nxp.com \
--cc=linux-usb@vger.kernel.org \
--cc=shawnguo@kernel.org \
--cc=thunder.leizhen@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).