From: Felipe Balbi <balbi@kernel.org>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: Manish Narani <manish.narani@xilinx.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Dependency of USB_DWC3_XILINX on ARCH_VERSAL
Date: Wed, 18 Aug 2021 13:02:19 +0300 [thread overview]
Message-ID: <87pmubf4rh.fsf@kernel.org> (raw)
In-Reply-To: <CAKXUXMwgWfX8+OvY0aCwRNukencwJERAZzU7p4eOLXQ2zv6rAg@mail.gmail.com>
Hi Lukas,
Lukas Bulwahn <lukas.bulwahn@gmail.com> writes:
> Commit 84770f028fab ("usb: dwc3: Add driver for Xilinx platforms")
> adds the config USB_DWC3_XILINX, which depends on the config
> ARCH_VERSAL. However, the config ARCH_VERSAL is not defined in the
> current mainline kernel repository.
>
> Will a definition of ARCH_VERSAL follow eventually (soon?) for
> mainline, is there just a further out-of-tree development for which
> the dependency is useful or is this just a mistake and can be
> corrected?
IMHO, we should have COMPILE_TEST added. Something like this:
modified drivers/usb/dwc3/Kconfig
@@ -151,7 +151,7 @@ config USB_DWC3_IMX8MP
config USB_DWC3_XILINX
tristate "Xilinx Platforms"
- depends on (ARCH_ZYNQMP || ARCH_VERSAL) && OF
+ depends on (ARCH_ZYNQMP || ARCH_VERSAL || COMPILE_TEST) && OF
default USB_DWC3
help
Support Xilinx SoCs with DesignWare Core USB3 IP.
Care to test, please
--
balbi
prev parent reply other threads:[~2021-08-18 10:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 6:47 Dependency of USB_DWC3_XILINX on ARCH_VERSAL Lukas Bulwahn
2021-08-18 10:02 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmubf4rh.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=manish.narani@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).