From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CE0CC433DB for ; Tue, 5 Jan 2021 13:01:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1EBF9229F0 for ; Tue, 5 Jan 2021 13:01:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727524AbhAENBV (ORCPT ); Tue, 5 Jan 2021 08:01:21 -0500 Received: from mail.kernel.org ([198.145.29.99]:56494 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727149AbhAENBU (ORCPT ); Tue, 5 Jan 2021 08:01:20 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 556CD229F0; Tue, 5 Jan 2021 13:00:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1609851639; bh=bk2fAAGdKAI4pOGSvmoeukZB7mglz/IgYfjQa6DN3lM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=bs6qCn4GcLAFliJpnskoTtdAj8carDljINO/ooxalWZ5xEhmY2eSMp1wEr+xehlWV +QVq0NPz5LfWC/3vhH8UTMMCCkd0mfqZmHLqIzde/sRHFYB9j89405x5Skh44oruMX 5M212QQvKejFd2sP4OAyQdGTAYOJE7rEALV+J/Wx2SmsC4zhR+yriRTjeQK8T0AZtI 0DfEt0fPhFjFo7oI+shAYdWax6D1qIpSjdHUmMU3k/OM0xUMtaXrFrzpkMyFMEQY4K 8qj6TWzZVlNSc6lZy8kIWye41WHmx3rgCqGHQ1r/1O+2GZwe9vFUhG5+Vt+4vaCICC onXlfvsQdO/kQ== From: Felipe Balbi To: Arnd Bergmann , Greg Kroah-Hartman , Jim Baxter Cc: Arnd Bergmann , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: gadget: select CONFIG_CRC32 In-Reply-To: <20210103214224.1996535-1-arnd@kernel.org> References: <20210103214224.1996535-1-arnd@kernel.org> Date: Tue, 05 Jan 2021 15:00:35 +0200 Message-ID: <87pn2jczd8.fsf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Arnd Bergmann writes: > From: Arnd Bergmann > > Without crc32 support, this driver fails to link: > > arm-linux-gnueabi-ld: drivers/usb/gadget/function/f_eem.o: in function `eem_unwrap': > f_eem.c:(.text+0x11cc): undefined reference to `crc32_le' > arm-linux-gnueabi-ld: drivers/usb/gadget/function/f_ncm.o:f_ncm.c:(.text+0x1e40): > more undefined references to `crc32_le' follow > > Fixes: 6d3865f9d41f ("usb: gadget: NCM: Add transmit multi-frame.") > Signed-off-by: Arnd Bergmann Acked-by: Felipe Balbi -- balbi