Hi, Greg Kroah-Hartman writes: >> >> > When building with Clang + -Wtautological-pointer-compare: >> >> > >> >> > drivers/usb/gadget/udc/bdc/bdc_ep.c:543:28: warning: comparison of >> >> > address of 'req->queue' equal to a null pointer is always false >> >> > [-Wtautological-pointer-compare] >> >> > if (req == NULL || &req->queue == NULL || &req->usb_req == NULL) >> >> > ~~~~~^~~~~ ~~~~ >> >> > drivers/usb/gadget/udc/bdc/bdc_ep.c:543:51: warning: comparison of >> >> > address of 'req->usb_req' equal to a null pointer is always false >> >> > [-Wtautological-pointer-compare] >> >> > if (req == NULL || &req->queue == NULL || &req->usb_req == NULL) >> >> > ~~~~~^~~~~~~ ~~~~ >> >> > 2 warnings generated. >> >> > >> >> > As it notes, these statements will always evaluate to false so remove >> >> > them. >> >> > >> >> > Fixes: efed421a94e6 ("usb: gadget: Add UDC driver for Broadcom USB3.0 device controller IP BDC") >> >> > Link: https://github.com/ClangBuiltLinux/linux/issues/749 >> >> > Signed-off-by: Nathan Chancellor >> >> >> >> It's now in my queue for v5.8. It doesn't really look like a bug fix, so >> >> it's not going in during v5.7-rc >> >> >> >> -- >> >> balbi >> > >> > Thank you for picking it up. It would be nice to see it in 5.7 since >> > we're enabling this warning and this is one of two outstanding >> > instances in -next and the other one's patch has been picked up plus the >> > patch itself is rather benign. Not to mention that I did send this patch >> > back in October. However, when it is merged into Linus' tree is >> > ultimately your call so I won't argue as long as it gets there >> > eventually. >> >> If Greg's okay with this patch going in during v5.7-rc, I can send it as >> a fix, no worries. Greg? > > Yes, clang build warnings fixes are valid fixes for the -rc period, and > I take them into stable where needed as well. Thanks for confirming, Greg. I'll move the commit to my testing/fixes -- balbi