linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Bjørn Mork" <bjorn@mork.no>
To: Hillf Danton <hdanton@sina.com>
Cc: Kristian Evensen <kristian.evensen@gmail.com>,
	syzbot <syzbot+b68605d7fadd21510de1@syzkaller.appspotmail.com>,
	andreyknvl@google.com, davem@davemloft.net,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	netdev@vger.kernel.org, syzkaller-bugs@googlegroups.com
Subject: Re: KASAN: global-out-of-bounds Read in qmi_wwan_probe
Date: Mon, 24 Jun 2019 18:26:51 +0200	[thread overview]
Message-ID: <87tvcf54qc.fsf@miraculix.mork.no> (raw)
In-Reply-To: <871rzj6sww.fsf@miraculix.mork.no> (Hillf Danton's message of "Mon, 24 Jun 2019 23:38:36 +0800")

Hillf Danton <hdanton@sina.com> writes:

> and wonder if the following works.
>
> -	info = (void *)&id->driver_info;
> +	info = (void *)id->driver_info;


Doh! Right you are.  Thanks to both you and Andrey for quick and good
help.

We obviously have some bad code patterns here, since this apparently
worked for Kristian by pure luck.


Bjørn

  parent reply	other threads:[~2019-06-24 16:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-24 12:07 KASAN: global-out-of-bounds Read in qmi_wwan_probe syzbot
2019-06-24 12:59 ` Bjørn Mork
2019-06-24 15:29   ` Andrey Konovalov
2019-06-24 16:26   ` Bjørn Mork [this message]
2019-06-24 17:16     ` Kristian Evensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tvcf54qc.fsf@miraculix.mork.no \
    --to=bjorn@mork.no \
    --cc=andreyknvl@google.com \
    --cc=davem@davemloft.net \
    --cc=hdanton@sina.com \
    --cc=kristian.evensen@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=syzbot+b68605d7fadd21510de1@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).