From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CA48C2D0A3 for ; Mon, 9 Nov 2020 07:00:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C164320789 for ; Mon, 9 Nov 2020 07:00:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604905253; bh=FisUgV7uscqua/AneDb62Q2lcmZKFJRrYhSkiLnuRrI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:List-ID:From; b=TVfIYeHRho+76mPqWKGD04gkst58Jq03GcwulUhQ6YrYgqrV2YD0A8STrqSp3jFhE eZ20iS0ordVVk1VG8JoqSa0lNVNcISPaP4SZJNCJFQozuyphS/6EUuvN3II2AHOYph 07VSQsTryj6dvyqWa6uKZHyrOAKSxcJRrJYu1unc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729615AbgKIHAx (ORCPT ); Mon, 9 Nov 2020 02:00:53 -0500 Received: from mail.kernel.org ([198.145.29.99]:37092 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728873AbgKIHAx (ORCPT ); Mon, 9 Nov 2020 02:00:53 -0500 Received: from saruman (88-113-213-94.elisa-laajakaista.fi [88.113.213.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 772C620665; Mon, 9 Nov 2020 07:00:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604905252; bh=FisUgV7uscqua/AneDb62Q2lcmZKFJRrYhSkiLnuRrI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=NOcf1lTWXRbb5fiUkYnOeAi6+47AtPpiqxDDSDG5cguHL8LGTTgLQNzo8CXyZJFso u2nyOkIbAtpMzMRlkUH/rQVmkx2UiqrD1P32QKR7fbyRHr4JmfkOAr/ml2OLCBeQjH 6Mkf8ktzW0O9XUvLkU81JxNEDt4k+hPcX/IW2X0Q= From: Felipe Balbi To: Ferry Toth , Andy Shevchenko Cc: "linux-usb@vger.kernel.org" , Thinh Nguyen , Heikki Krogerus , Jack Pham , Mathias Nyman Subject: Re: BUG with linux 5.9.0 with dwc3 in gadget mode In-Reply-To: References: <913dccca-500d-1938-b199-6eb67cfb60cc@gmail.com> <874kmpf583.fsf@kernel.org> <976cea12-e54e-fbca-6c53-e6ef5c554094@synopsys.com> <645b6ddc-d4f5-3f5b-b85f-b3d27fc365f5@synopsys.com> <2b6586e6-528c-86e8-9d92-0061bc44866d@gmail.com> <2cc783ac-6b71-190b-49fc-9e2bceeacd4b@gmail.com> <920590dc-5430-7f8b-b2e1-1a4c37f4dfbe@synopsys.com> <0089306e-e2ca-9a53-6ffb-202d028050ce@gmail.com> <30ab00e4-53ae-fd9e-1689-c94078a31625@gmail.com> <871rhin1yt.fsf@kernel.org> <87eel7q9bk.fsf@kernel.org> <326aa23e-fabd-f3d6-4778-d036858413a2@gmail.com> <87blgar2ow.fsf@kernel.org> <87d00py4sj.fsf@kernel.org> Date: Mon, 09 Nov 2020 09:00:47 +0200 Message-ID: <87wnyv2ew0.fsf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Hi, Ferry Toth writes: >> I don't suppose you have a USB sniffer, do you? > No, I don't have one of those. >> Andy, could you see if you can reproduce the same behavior with a >> sniffer? It really seems like this either caused by the host side or >> something outside dwc3. Perhaps the PHY is going bonkers? >> >> cheers > > But got other inspiration: like you say dwc3 is behaving normally, so > problem might be elsewhere right? > > Now, to make gadget working I needed to apply the experiment from Jack Pham: > > https://github.com/edison-fw/linux/commit/da90cb63fc8f0ce18805f262d4d6b5b4d8c11d5c > > But now Jack has already sent in "[PATCH v3] usb: gadget: audio: Free > requests only after callback" > > So, removing the experiment and adding PATCH 3, this issue appears to go > away. > > And indeed this fixes a problem in u_audio.c, not in dwc3. > > Thanks all, I'm looking forward to the patch to land in 5.10-rc3/4. Awesome!!! Do you want to reply to Jack's patch with a Tested-by? -- balbi