From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70C59C4338F for ; Tue, 24 Aug 2021 08:18:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4CCD261248 for ; Tue, 24 Aug 2021 08:18:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235347AbhHXITP (ORCPT ); Tue, 24 Aug 2021 04:19:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:54878 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233692AbhHXITL (ORCPT ); Tue, 24 Aug 2021 04:19:11 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 21F1461220; Tue, 24 Aug 2021 08:18:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629793107; bh=nykxD81K9jux0Z9cYpoVeP6Sogs7zBWpCbzPYz9PWvo=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=DcUkzqlfF30qlcEzv0MWg1icXwzmG6RXblOkrmMUnY2rEbGruDFmV4TR4xnUWJIQj 6cqSjYVtIhd+XxZOTk6GQ3I8oQTjBYzF9HOro4u1MlCEQm8dYAw1d+0CmF23YjQYJA 6SBw/inxQ9nN5PUU2QzDIvT/PTY/Me5fO3eDwu5O09sw0GhO6BRRUDoZIJTWkDgOsb GVVC7taJd76uqlY/mH43Em86D6aCs4xr9BlQ2qV1tSawheKp5t3yxFVWuaoHBFSHFm SE5nGnujtPygw2A0laSYhpBeNspH1DgnIASkmrelOO0J4+ZxE337sR+BlRZyDFNi3A 9jF5IKearMCGw== References: <20210823222458.3760-1-wcheng@codeaurora.org> User-agent: mu4e 1.6.4; emacs 27.2 From: Felipe Balbi To: Wesley Cheng Cc: gregkh@linuxfoundation.org, Thinh.Nguyen@synopsys.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, jackp@codeaurora.org Subject: Re: [PATCH v4] usb: dwc3: gadget: Stop EP0 transfers during pullup disable Date: Tue, 24 Aug 2021 11:17:59 +0300 In-reply-to: <20210823222458.3760-1-wcheng@codeaurora.org> Message-ID: <87y28r6ysv.fsf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Wesley Cheng writes: > During a USB cable disconnect, or soft disconnect scenario, a pending > SETUP transaction may not be completed, leading to the following > error: > > dwc3 a600000.dwc3: timed out waiting for SETUP phase > > If this occurs, then the entire pullup disable routine is skipped and > proper cleanup and halting of the controller does not complete. > > Instead of returning an error (which is ignored from the UDC > perspective), allow the pullup disable routine to continue, which > will also handle disabling of EP0/1. This will end any active > transfers as well. Ensure to clear any delayed_status also, as the > timeout could happen within the STATUS stage. > > Signed-off-by: Wesley Cheng > --- > Changes in v4: > - Fixed formatting and typos in commit text > - Removed braces due to the removal of the return statement > > Changes in v3: > - Added suggestion by Thinh to change dev_err to dev_warn > > Changes in v2: > - Removed calls to dwc3_ep0_end_control_data() and just allow the ep disables > on EP0 handle the proper ending of transfers. > - Ensure that delayed_status is cleared, as ran into enumeration issues if the > SETUP transaction fails on a STATUS stage. Saw delayed_status == TRUE on the > next connect, which blocked further SETUP transactions to be handled. > > drivers/usb/dwc3/gadget.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c > index 5d084542718d..63f6d9f2a692 100644 > --- a/drivers/usb/dwc3/gadget.c > +++ b/drivers/usb/dwc3/gadget.c > @@ -2428,10 +2428,8 @@ static int dwc3_gadget_pullup(struct usb_gadget *g, int is_on) > > ret = wait_for_completion_timeout(&dwc->ep0_in_setup, > msecs_to_jiffies(DWC3_PULL_UP_TIMEOUT)); > - if (ret == 0) { > - dev_err(dwc->dev, "timed out waiting for SETUP phase\n"); > - return -ETIMEDOUT; > - } > + if (ret == 0) > + dev_warn(dwc->dev, "timed out waiting for SETUP phase\n"); looks like a bug fix. Do we need to Cc stable? -- balbi