* [PATCH] usb: dwc3: trace: Remove unused fields in dwc3_log_trb
@ 2021-05-27 1:29 Jack Pham
2021-05-28 10:06 ` Felipe Balbi
0 siblings, 1 reply; 2+ messages in thread
From: Jack Pham @ 2021-05-27 1:29 UTC (permalink / raw)
To: Felipe Balbi; +Cc: linux-usb, Mayank Rana, Jack Pham
From: Mayank Rana <mrana@codeaurora.org>
Commit 0bd0f6d201eb ("usb: dwc3: gadget: remove allocated/queued request
tracking") removed the allocated & queued fields from struct dwc3_ep
but neglected to also remove them from the dwc3_log_trb event class's
TP_STRUCT definition which are now unused. Remove them to save eight
bytes per trace event entry.
Signed-off-by: Mayank Rana <mrana@codeaurora.org>
Signed-off-by: Jack Pham <jackp@codeaurora.org>
---
drivers/usb/dwc3/trace.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/usb/dwc3/trace.h b/drivers/usb/dwc3/trace.h
index 51d18e8d1602..cb998ba50fea 100644
--- a/drivers/usb/dwc3/trace.h
+++ b/drivers/usb/dwc3/trace.h
@@ -222,8 +222,6 @@ DECLARE_EVENT_CLASS(dwc3_log_trb,
TP_STRUCT__entry(
__string(name, dep->name)
__field(struct dwc3_trb *, trb)
- __field(u32, allocated)
- __field(u32, queued)
__field(u32, bpl)
__field(u32, bph)
__field(u32, size)
--
2.24.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: dwc3: trace: Remove unused fields in dwc3_log_trb
2021-05-27 1:29 [PATCH] usb: dwc3: trace: Remove unused fields in dwc3_log_trb Jack Pham
@ 2021-05-28 10:06 ` Felipe Balbi
0 siblings, 0 replies; 2+ messages in thread
From: Felipe Balbi @ 2021-05-28 10:06 UTC (permalink / raw)
To: Jack Pham; +Cc: linux-usb, Mayank Rana, Jack Pham
[-- Attachment #1: Type: text/plain, Size: 582 bytes --]
Jack Pham <jackp@codeaurora.org> writes:
> From: Mayank Rana <mrana@codeaurora.org>
>
> Commit 0bd0f6d201eb ("usb: dwc3: gadget: remove allocated/queued request
> tracking") removed the allocated & queued fields from struct dwc3_ep
> but neglected to also remove them from the dwc3_log_trb event class's
> TP_STRUCT definition which are now unused. Remove them to save eight
> bytes per trace event entry.
>
> Signed-off-by: Mayank Rana <mrana@codeaurora.org>
> Signed-off-by: Jack Pham <jackp@codeaurora.org>
Acked-by: Felipe Balbi <balbi@kernel.org>
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 511 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-28 10:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-27 1:29 [PATCH] usb: dwc3: trace: Remove unused fields in dwc3_log_trb Jack Pham
2021-05-28 10:06 ` Felipe Balbi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).