Hi, EJ Hsu writes: > Gadget driver should always use config_ep_by_speed() to initialize > usb_ep struct according to usb device's operating speed. Otherwise, > usb_ep struct may be wrong if usb devcie's operating speed is changed. your commit log doesn't match the patch body. What gives? > Signed-off-by: EJ Hsu > --- > drivers/usb/gadget/function/f_ecm.c | 4 ++++ > drivers/usb/gadget/function/f_rndis.c | 1 + > 2 files changed, 5 insertions(+) > > diff --git a/drivers/usb/gadget/function/f_ecm.c b/drivers/usb/gadget/function/f_ecm.c > index 6ce044008cf6..494fe4e38a65 100644 > --- a/drivers/usb/gadget/function/f_ecm.c > +++ b/drivers/usb/gadget/function/f_ecm.c > @@ -623,6 +623,10 @@ static void ecm_disable(struct usb_function *f) > > if (ecm->port.in_ep->enabled) > gether_disconnect(&ecm->port); > + else { coding style. If one branch has {}, both branches should have {} ;-) -- balbi