From: Evgeny Boger <boger@wirenboard.com>
To: andre.przywara@arm.com
Cc: icenowy@aosc.io, jernej.skrabec@gmail.com, kishon@ti.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
linux-sunxi@googlegroups.com, linux-sunxi@lists.linux.dev,
linux-usb@vger.kernel.org, megous@megous.com, mripard@kernel.org,
robh@kernel.org, samuel@sholland.org, vkoul@kernel.org,
wens@csie.org
Subject: Re: [PATCH v7 15/19] phy: sun4i-usb: Add support for the H616 USB PHY
Date: Mon, 12 Jul 2021 19:50:22 +0300 [thread overview]
Message-ID: <880c62ea-4844-04f7-7b40-a9e8a14de202@wirenboard.com> (raw)
In-Reply-To: <20210615110636.23403-16-andre.przywara@arm.com>
Hi Andre!
> The USB PHY used in the Allwinner H616 SoC inherits some traits from its
> various predecessors: it has four full PHYs like the H3, needs some
> extra bits to be set like the H6, and puts SIDDQ on a different bit like
> the A100. Plus it needs this weird PHY2 quirk.
>
> Name all those properties in a new config struct and assign a new
> compatible name to it.
>
> Signed-off-by: Andre Przywara<andre.przywara@arm.com>
> ---
> drivers/phy/allwinner/phy-sun4i-usb.c <https://lore.kernel.org/linux-sunxi/20210615110636.23403-16-andre.przywara@arm.com/#Z30drivers:phy:allwinner:phy-sun4i-usb.c> | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff
> <https://lore.kernel.org/linux-sunxi/20210615110636.23403-16-andre.przywara@arm.com/#iZ30drivers:phy:allwinner:phy-sun4i-usb.c>
> --git a/drivers/phy/allwinner/phy-sun4i-usb.c
> b/drivers/phy/allwinner/phy-sun4i-usb.c index
> 316ef5fca831..85a9771280b7 100644 ---
> a/drivers/phy/allwinner/phy-sun4i-usb.c +++
> b/drivers/phy/allwinner/phy-sun4i-usb.c @@ -1024,6 +1024,17 @@ static
> const struct sun4i_usb_phy_cfg sun50i_h6_cfg = { .missing_phys = BIT(1) | BIT(2),
> };
>
> +static const struct sun4i_usb_phy_cfg sun50i_h616_cfg = { + .num_phys
> = 4, + .type = sun50i_h6_phy,
Since this usb phy is considerable different from the one in H6,
wouldn't it better to define a new phy type here? The way the driver is
designed, I would expect the type to be shared by more or less identical
parts.
Honestly, I think it would be better to get rid of .type in the
sun4i_usb_phy_cfg completely replacing it by a couple more traits in
.cfg. It's impossible to know for sure which Allwinner parts really
share the identical revision of this hardware.
> + .disc_thresh = 3, + .phyctl_offset = REG_PHYCTL_A33, +
> .dedicated_clocks = true, + .phy0_dual_route = true, +
> .hci_phy_ctl_clear = PHY_CTL_SIDDQ, + .needs_phy2_siddq = true, +}; + static const struct of_device_id sun4i_usb_phy_of_match[] = {
> { .compatible = "allwinner,sun4i-a10-usb-phy", .data = &sun4i_a10_cfg },
> { .compatible = "allwinner,sun5i-a13-usb-phy", .data = &sun5i_a13_cfg },
> @@ -1038,6 +1049,7 @@ static const struct of_device_id
> sun4i_usb_phy_of_match[] = { { .compatible = "allwinner,sun50i-a64-usb-phy",
> .data = &sun50i_a64_cfg},
> { .compatible = "allwinner,sun50i-h6-usb-phy", .data = &sun50i_h6_cfg },
> + { .compatible = "allwinner,sun50i-h616-usb-phy", .data =
> &sun50i_h616_cfg }, { },
> };
> MODULE_DEVICE_TABLE(of, sun4i_usb_phy_of_match);
> --
> 2.17.5
>
prev parent reply other threads:[~2021-07-12 16:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210615110636.23403-1-andre.przywara@arm.com>
2021-06-15 11:06 ` [PATCH v7 10/19] dt-bindings: usb: Add H616 compatible string Andre Przywara
2021-06-15 11:06 ` [PATCH v7 11/19] dt-bindings: usb: sunxi-musb: " Andre Przywara
2021-06-15 11:06 ` [PATCH v7 12/19] phy: sun4i-usb: Rework HCI PHY (aka. "pmu_unk1") handling Andre Przywara
2021-06-15 11:06 ` [PATCH v7 13/19] phy: sun4i-usb: Allow reset line to be shared Andre Przywara
2021-06-15 11:25 ` Philipp Zabel
2021-06-15 11:06 ` [PATCH v7 14/19] phy: sun4i-usb: Introduce port2 SIDDQ quirk Andre Przywara
2021-06-21 4:36 ` Vinod Koul
2021-06-21 9:14 ` Andre Przywara
2021-06-15 11:06 ` [PATCH v7 15/19] phy: sun4i-usb: Add support for the H616 USB PHY Andre Przywara
2021-07-12 16:50 ` Evgeny Boger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=880c62ea-4844-04f7-7b40-a9e8a14de202@wirenboard.com \
--to=boger@wirenboard.com \
--cc=andre.przywara@arm.com \
--cc=icenowy@aosc.io \
--cc=jernej.skrabec@gmail.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-sunxi@googlegroups.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux-usb@vger.kernel.org \
--cc=megous@megous.com \
--cc=mripard@kernel.org \
--cc=robh@kernel.org \
--cc=samuel@sholland.org \
--cc=vkoul@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).