Linux-USB Archive on lore.kernel.org
 help / color / Atom feed
From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Jan Schmidt <jan@centricular.com>, linux-usb@vger.kernel.org
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Subject: Re: [PATCH] xhci: Check all endpoints for LPM timeout
Date: Fri, 13 Sep 2019 15:58:11 +0300
Message-ID: <896688f6-8486-3826-ee74-a225936f824d@linux.intel.com> (raw)
In-Reply-To: <20190912144921.368-1-jan@centricular.com>

On 12.9.2019 17.49, Jan Schmidt wrote:
> If an endpoint is encountered that returns USB3_LPM_DEVICE_INITIATED, keep
> checking further endpoints, as there might be periodic endpoints later
> that return USB3_LPM_DISABLED due to shorter service intervals.
> 
> Without this, the code can set too high a maximum-exit-latency and
> prevent the use of multiple USB3 cameras that should be able to work.
> 
> Signed-off-by: Jan Schmidt <jan@centricular.com>
> Tested-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
>   drivers/usb/host/xhci.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> index 03d1e552769b..1986b88661fc 100644
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -4673,12 +4673,12 @@ static int xhci_update_timeout_for_endpoint(struct xhci_hcd *xhci,
>   	alt_timeout = xhci_call_host_update_timeout_for_endpoint(xhci, udev,
>   		desc, state, timeout);
>   
> -	/* If we found we can't enable hub-initiated LPM, or
> +	/* If we found we can't enable hub-initiated LPM, and
>   	 * the U1 or U2 exit latency was too high to allow
> -	 * device-initiated LPM as well, just stop searching.
> +	 * device-initiated LPM as well, then we will disable LPM
> +	 * for this device, so stop searching any further.
>   	 */
> -	if (alt_timeout == USB3_LPM_DISABLED ||
> -			alt_timeout == USB3_LPM_DEVICE_INITIATED) {
> +	if (alt_timeout == USB3_LPM_DISABLED) {
>   		*timeout = alt_timeout;
>   		return -E2BIG;
>   	}
> 

Thanks, nice catch. Adding to queue.

While looking at this I see we have a similar issue if driver has
"disable_hub_initiated_lpm" flag set.

xhci_get_timeout_no_hub_lpm() might return USB3_LPM_DEVICE_INITIATED
before we check if periodic endpoints would require disabling LPM
completely.

xhci_calculate_lpm_timeout()
...
     for (i = 0; i < config->desc.bNumInterfaces; i++) {
         ...
         if (intf->dev.driver) {
             ...
             if (driver && driver->disable_hub_initiated_lpm) {
                 return xhci_get_timeout_no_hub_lpm(udev, state);

I'll write a patch for that

-Mathias

  parent reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-12 14:49 Jan Schmidt
2019-09-12 15:14 ` Philipp Zabel
2019-09-13 12:58 ` Mathias Nyman [this message]
2019-09-13 13:46   ` Jan Schmidt

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=896688f6-8486-3826-ee74-a225936f824d@linux.intel.com \
    --to=mathias.nyman@linux.intel.com \
    --cc=jan@centricular.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-USB Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-usb/0 linux-usb/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-usb linux-usb/ https://lore.kernel.org/linux-usb \
		linux-usb@vger.kernel.org linux-usb@archiver.kernel.org
	public-inbox-index linux-usb


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-usb


AGPL code for this site: git clone https://public-inbox.org/ public-inbox