archive mirror
 help / color / mirror / Atom feed
From: Thinh Nguyen <>
To: Greg Kroah-Hartman <>,
	Thinh Nguyen <>
Cc: Felipe Balbi <>,
	"" <>,
	John Youn <>
Subject: Re: [PATCH] usb: dwc3: gadget: Remove check for bounded driver
Date: Fri, 5 Feb 2021 09:55:01 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Greg Kroah-Hartman wrote:
> On Fri, Feb 05, 2021 at 09:39:37AM +0000, Thinh Nguyen wrote:
>> Greg Kroah-Hartman wrote:
>>> On Wed, Feb 03, 2021 at 08:14:37PM -0800, Thinh Nguyen wrote:
>>>> The check for bounded gadget driver in dwc3_gadget_start() was to
>>>> prevent going through the initialization again without any cleanup. With
>>>> a recent update, the UDC framework guarantees this won't happen while
>>>> the UDC is started. Also, this check doesn't prevent requesting threaded
>>>> irq to the same dev_id, which will mess up the irq freeing logic. Let's
>>>> remove it.
>>> What "recent update" caused this?  Is this a fix for something that
>>> needs to be backported?  If so, can you provide a "Fixes:" tag on here?
>>> Or is this just a general cleanup that is good to do now.
>>> thanks,
>>> greg k-h
>> It's general cleanup. The "recent update" is not in mainline yet but on
>> your "usb-next" branch so I'm not sure how to properly reference it.
>> But here's the commit on your branch I was referring to: 49d08cfc7830
>> ("usb: udc: core: Introduce started state")
> Please refer to this commit just like this, as the id is not going to
> change.  Can you redo this patch with that information in it?
> thanks,
> greg k-h

Will do.


      reply	other threads:[~2021-02-05 23:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-04  4:14 [PATCH] usb: dwc3: gadget: Remove check for bounded driver Thinh Nguyen
2021-02-05  9:26 ` Greg Kroah-Hartman
2021-02-05  9:39   ` Thinh Nguyen
2021-02-05  9:41     ` Greg Kroah-Hartman
2021-02-05  9:55       ` Thinh Nguyen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).