From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FB76C56202 for ; Wed, 18 Nov 2020 11:25:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 205AF2075A for ; Wed, 18 Nov 2020 11:25:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727189AbgKRLZW convert rfc822-to-8bit (ORCPT ); Wed, 18 Nov 2020 06:25:22 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:54749 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726733AbgKRLZU (ORCPT ); Wed, 18 Nov 2020 06:25:20 -0500 Received: from mail-pf1-f198.google.com ([209.85.210.198]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1kfLaP-0000y6-NY for linux-usb@vger.kernel.org; Wed, 18 Nov 2020 11:25:17 +0000 Received: by mail-pf1-f198.google.com with SMTP id u3so968120pfm.22 for ; Wed, 18 Nov 2020 03:25:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=r7x4FLD1g1lFiB/rjBYtCrwkSnWVEPF+U90EeU7fGs4=; b=pHkLtyhTe5Gv5+L5Erig9ItuZEockQwhetjUlAIHG34RmCryPdUaJ/o3GyVNsWFsos lWQTAp2Yl5tbfIrHqodKTcyxnqWYn4xslCUCf8zW1I/xW9uJbSi6XWiNz18oQOSO3+ou 6h++5hkHv+EWj1V3nIbmiPJ05u++hjywNXwfxwfru2fzbBwpvhd7LV7OxPJbhAhcGClY uoQyuAF/UbgoZwRvS2hT4mpTf/jk7XvQRNqyax8CaVIXQklQrKWFoW3CLeuuNUOcMzr+ BpvriCJpPSl3o6IXLv67pRKuoR/u/cExEXNsKBl3FCJ78acuW7Uak+FxKsuQLcMoXeZV 5zTQ== X-Gm-Message-State: AOAM532tNn0GGw1TmufC4B+S7TymeGlrtpi5spZNxvKGtoP1dV+ntDnK fLLz8cE2JBPnliQe+9cMp9EOJbEfghdb2X8h9dAyf/dH/tUJC24/xm6kap73sXgCZNPOwegcLZ2 gf2fyXDg8+sRCvUPwU6rMXhd2h8dXJiFLsy6yzw== X-Received: by 2002:a17:90a:cb93:: with SMTP id a19mr3350481pju.99.1605698716357; Wed, 18 Nov 2020 03:25:16 -0800 (PST) X-Google-Smtp-Source: ABdhPJyrZrei/lPBiaqSz316HZD8X9lUfdxdrVtEhbhkaaY76B2qM77fQz03JGOPMmHQuR6flNxK2A== X-Received: by 2002:a17:90a:cb93:: with SMTP id a19mr3350463pju.99.1605698716006; Wed, 18 Nov 2020 03:25:16 -0800 (PST) Received: from [192.168.1.208] (220-133-187-190.HINET-IP.hinet.net. [220.133.187.190]) by smtp.gmail.com with ESMTPSA id m20sm23967992pfk.31.2020.11.18.03.25.13 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Nov 2020 03:25:15 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.20.0.2.21\)) Subject: Re: [PATCH] USB: quirks: Add USB_QUIRK_DISCONNECT_SUSPEND quirk for Lenovo A630Z TIO built-in usb-audio card From: Kai-Heng Feng In-Reply-To: <20201118110639.7455-1-penghao@uniontech.com> Date: Wed, 18 Nov 2020 19:25:07 +0800 Cc: Greg Kroah-Hartman , johan@kernel.org, jonathan@jdcox.net, tomasz@meresinski.eu, hdegoede@redhat.com, dlaz@chromium.org, richard.o.dodd@gmail.com, kerneldev@karsmulder.nl, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: <91C616BC-3B99-4BB5-AEBE-6975CBFB29BA@canonical.com> References: <20201118110639.7455-1-penghao@uniontech.com> To: penghao X-Mailer: Apple Mail (2.3654.20.0.2.21) Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Hi penghao, > On Nov 18, 2020, at 19:06, penghao wrote: > > Add a USB_QUIRK_DISCONNECT_SUSPEND quirk for the Lenovo TIO built-in > usb-audio. when A630Z going into S3,the system immediately wakeup 7-8 > seconds later by usb-audio disconnect interrupt to avoids the issue. > > Seeking a better fix, we've tried a lot of things, including: > - Check that the device's power/wakeup is disabled > - Check that remote wakeup is off at the USB level > - All the quirks in drivers/usb/core/quirks.c > e.g. USB_QUIRK_RESET_RESUME, > USB_QUIRK_RESET, > USB_QUIRK_IGNORE_REMOTE_WAKEUP, > USB_QUIRK_NO_LPM. > > but none of that makes any difference. > > There are no errors in the logs showing any suspend/resume-related issues. > When the system wakes up due to the modem, log-wise it appears to be a > normal resume. > > Introduce a quirk to disable the port during suspend when the modem is > detected. > > Changes since v4 > - Fixed add a blank line > > Changes since v3 > - Fixed spelling error on appropriate > > Changes since v2 > - Add Changes commit format > > Changes since v1 > - Change subject form "ALSA" to "USB:" > - Adjust to appropriate line > > Signed-off-by: penghao > --- > drivers/usb/core/quirks.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c > index 7c1198f80c23..26b852ae0d85 100644 > --- a/drivers/usb/core/quirks.c > +++ b/drivers/usb/core/quirks.c > @@ -410,6 +410,10 @@ static const struct usb_device_id usb_quirk_list[] = { > { USB_DEVICE(0x1532, 0x0116), .driver_info = > USB_QUIRK_LINEAR_UFRAME_INTR_BINTERVAL }, > > + /* Lenovo ThinkCenter A630Z TI024Gen3 usb-audio */ > + { USB_DEVICE(0x17ef, 0xa012), .driver_info = > + USB_QUIRK_DISCONNECT_SUSPEND }, > + Would it be possible to enable dynamic debug, reproduce the issue, and attach dmesg here? i.e. # echo 'file drivers/usb/* +p; file drivers/usb/host/* +p' > /sys/kernel/debug/dynamic_debug/control # echo mem > /sys/power/state ... and attach dmesg here. Kai-Heng > /* BUILDWIN Photo Frame */ > { USB_DEVICE(0x1908, 0x1315), .driver_info = > USB_QUIRK_HONOR_BNUMINTERFACES }, > -- > 2.11.0 > > >