From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 043ADC433FE for ; Wed, 29 Sep 2021 15:54:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E58B5613A5 for ; Wed, 29 Sep 2021 15:54:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345452AbhI2Pzo (ORCPT ); Wed, 29 Sep 2021 11:55:44 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:10361 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345446AbhI2Pzl (ORCPT ); Wed, 29 Sep 2021 11:55:41 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1632930840; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=mD8/cVzeUyAM6c/UabO55pm1CfQiL17d4b03cqAJbm8=; b=ZiZNAKOowOnvCmyahYVZ33Ls4jvT3BaspkfEygXuB2Za4t4io6Vbsrncg6f++3pE1jso4UDe Xlh7E55w1Jp4wY/jKkh3wNnZ3HdwUk9s7K9pcpKHU6clpScwHiJWvoXKAQhuVsVx5gbVI62g Usv1mjvwc2FgRXPKY7WDLLh0z/Y= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyIxZTE2YSIsICJsaW51eC11c2JAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n03.prod.us-east-1.postgun.com with SMTP id 61548c17713d5d6f962ffaf7 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 29 Sep 2021 15:53:59 GMT Sender: pmaliset=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 1A7DEC43617; Wed, 29 Sep 2021 15:53:58 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: pmaliset) by smtp.codeaurora.org (Postfix) with ESMTPSA id 671A2C4360C; Wed, 29 Sep 2021 15:53:56 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 29 Sep 2021 21:23:55 +0530 From: Prasad Malisetty To: Stephen Boyd Cc: agross@kernel.org, bhelgaas@google.com, bjorn.andersson@linaro.org, lorenzo.pieralisi@arm.com, robh+dt@kernel.org, svarbanov@mm-sol.com, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, dianders@chromium.org, mka@chromium.org, vbadigan@codeaurora.org, sallenki@codeaurora.org, manivannan.sadhasivam@linaro.org Subject: Re: [PATCH v9 3/4] arm64: dts: qcom: sc7280: Add PCIe nodes for IDP board In-Reply-To: References: <1632837350-12100-1-git-send-email-pmaliset@codeaurora.org> <1632837350-12100-4-git-send-email-pmaliset@codeaurora.org> Message-ID: <92e500fa87f726791383d1b6a2532699@codeaurora.org> X-Sender: pmaliset@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On 2021-09-29 02:22, Stephen Boyd wrote: > Quoting Prasad Malisetty (2021-09-28 06:55:49) >> Enable PCIe controller and PHY for sc7280 IDP board. >> Add specific NVMe GPIO entries for SKU1 and SKU2 support. >> >> Signed-off-by: Prasad Malisetty >> --- >> arch/arm64/boot/dts/qcom/sc7280-idp.dts | 9 ++++++ >> arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 54 >> ++++++++++++++++++++++++++++++++ >> arch/arm64/boot/dts/qcom/sc7280-idp2.dts | 9 ++++++ >> 3 files changed, 72 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dts >> b/arch/arm64/boot/dts/qcom/sc7280-idp.dts >> index 64fc22a..1562386 100644 >> --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dts >> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dts >> @@ -61,6 +61,15 @@ >> modem-init; >> }; >> >> +&nvme_pwren_pin { >> + pins = "gpio19"; >> +}; > > This should move to the bottom in the "pinctrl" section. > >> + >> +&nvme_3v3_regulators { >> + gpio = <&tlmm 19 GPIO_ACTIVE_HIGH>; >> + enable-active-high; > > The enable-active-high can be in the idp.dtsi file? That doesn't seem > to > change. > >> +}; >> + >> &pmk8350_vadc { >> pmr735a_die_temp { >> reg = ; >> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi >> b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi >> index def22ff..5b5505f 100644 >> --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi >> @@ -31,6 +31,17 @@ >> linux,can-disable; >> }; >> }; >> + >> + nvme_3v3_regulators: nvme-3v3-regulators { > > Why plural? Isn't it a single regulator? > >> + compatible = "regulator-fixed"; >> + regulator-name = "VLDO_3V3"; >> + >> + regulator-min-microvolt = <3300000>; >> + regulator-max-microvolt = <3300000>; >> + >> + pinctrl-names = "default"; >> + pinctrl-0 = <&nvme_pwren_pin>; >> + }; >> }; >> >> &apps_rsc { >> @@ -220,6 +231,42 @@ >> modem-init; >> }; >> >> +&pcie1 { >> + status = "okay"; >> + perst-gpio = <&tlmm 2 GPIO_ACTIVE_LOW>; >> + >> + vddpe-3v3-supply = <&nvme_3v3_regulators>; >> + >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pcie1_default_state>; >> +}; >> + >> +&pcie1_phy { >> + status = "okay"; >> + >> + vdda-phy-supply = <&vreg_l10c_0p8>; >> + vdda-pll-supply = <&vreg_l6b_1p2>; >> +}; >> + >> +&pcie1_default_state { > > I thought the node would be split into a reset config node and a wake > config node. Is that not being done for some reason? The pinctrl-0 > would > look like > > pinctrl-0 = <&pcie1_default_state>, <&pcie1_reset_n>, <&pcie1_wake_n>; > >> + reset-n { >> + pins = "gpio2"; >> + function = "gpio"; >> + >> + drive-strength = <16>; >> + output-low; >> + bias-disable; >> + }; >> + >> + wake-n { >> + pins = "gpio3"; >> + function = "gpio"; >> + >> + drive-strength = <2>; >> + bias-pull-up; >> + }; >> +}; >> + >> &pmk8350_vadc { >> pmk8350_die_temp { >> reg = ; >> @@ -489,3 +536,10 @@ >> bias-pull-up; >> }; >> }; >> + >> +&tlmm { >> + nvme_pwren_pin: nvme-pwren-pin { >> + function = "gpio"; >> + bias-pull-up; >> + }; >> +}; >> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp2.dts >> b/arch/arm64/boot/dts/qcom/sc7280-idp2.dts >> index 1fc2add..0548cb6 100644 >> --- a/arch/arm64/boot/dts/qcom/sc7280-idp2.dts >> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp2.dts >> @@ -21,3 +21,12 @@ >> stdout-path = "serial0:115200n8"; >> }; >> }; >> + >> +&nvme_pwren_pin { >> + pins = "gpio51"; >> +}; > > The pin config can go to a pinctrl section at the bottom of this file? > Hi Stephen, Thanks for the review and comments. Sure, I will address all the comments and incorporate the changes in next version series. Thanks -Prasad >> + >> +&nvme_3v3_regulators { >> + gpio = <&tlmm 51 GPIO_ACTIVE_HIGH>; >> + enable-active-high; >> +};