archive mirror
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <>
To: Johan Hovold <>,
Cc: Greg Kroah-Hartman <>,
Subject: Re: [PATCH] USB: serial: drop bogus to_usb_serial_port() checks
Date: Mon, 8 Feb 2021 18:06:38 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

[-- Attachment #1.1: Type: text/plain, Size: 420 bytes --]

On 2/8/21 4:48 PM, Johan Hovold wrote:
> The to_usb_serial_port() macro is implemented using container_of() so
> there's no need to check for NULL.
> Note that neither bus match() or probe() is ever called with a NULL
> struct device pointer so the checks weren't just misplaced.
> Signed-off-by: Johan Hovold <>

Reviewed-by: Uwe Kleine-König <>


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  parent reply	other threads:[~2021-02-08 17:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-08 15:48 [PATCH] USB: serial: drop bogus to_usb_serial_port() checks Johan Hovold
2021-02-08 16:43 ` Greg Kroah-Hartman
2021-02-08 17:06 ` Uwe Kleine-König [this message]
2021-02-09 12:16   ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).