linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ajay Gupta <ajayg@nvidia.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Ajay Gupta <ajaykuee@gmail.com>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: RE: [PATCH v4] usb: typec: ucsi: add support for separate DP altmode devices
Date: Fri, 6 Sep 2019 16:56:44 +0000	[thread overview]
Message-ID: <BN7PR12MB27230ABB5F93E7ED007665EADCBA0@BN7PR12MB2723.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20190906134318.GD30048@kuha.fi.intel.com>

Hi Heikki,

> > CCGx controller used on NVIDIA GPU card has two separate display
> > altmode for two DP pin assignments. UCSI specification doesn't
> > prohibits using separate display altmode.
> >
> > Current UCSI Type-C framework expects only one display altmode for all
> > DP pin assignment. This patch squashes two separate display altmode
> > into single altmode to support controllers with separate display
> > altmode. We first read all the alternate modes of connector and then
> > run through it to know if there are separate display altmodes. If so,
> > it prepares a new port altmode set after squashing two or more
> > separate altmodes into one.
> 
> This patch has still some stylistic issues (like the comments: please use the
> same style that was used previously in the driver), 
Ok, I will fix them in v5.

> but besides those, I'm still not sure I understand why couldn't we isolate 
> the solution to ucsi_ccg.c. 
Please check my comments at [1] explaining why it can't be isolated to
ucsi_ccg.c.

[1] https://marc.info/?l=linux-usb&m=156625373324903&w=2 

Thanks
> nvpublic
> I have to take a better look at this next week.
> 
> I'm sorry this takes so long.
> 
> Br,
> 
> --
> heikki

      reply	other threads:[~2019-09-06 16:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-04 16:27 [PATCH v4] usb: typec: ucsi: add support for separate DP altmode devices Ajay Gupta
2019-09-06 13:43 ` Heikki Krogerus
2019-09-06 16:56   ` Ajay Gupta [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BN7PR12MB27230ABB5F93E7ED007665EADCBA0@BN7PR12MB2723.namprd12.prod.outlook.com \
    --to=ajayg@nvidia.com \
    --cc=ajaykuee@gmail.com \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).