From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C119EC4649B for ; Fri, 5 Jul 2019 11:40:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8E28A218D0 for ; Fri, 5 Jul 2019 11:40:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cadence.com header.i=@cadence.com header.b="tC9GYqHK"; dkim=pass (1024-bit key) header.d=cadence.com header.i=@cadence.com header.b="HxiHoLTJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728563AbfGELkV (ORCPT ); Fri, 5 Jul 2019 07:40:21 -0400 Received: from mx0b-0014ca01.pphosted.com ([208.86.201.193]:48014 "EHLO mx0a-0014ca01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728087AbfGELkV (ORCPT ); Fri, 5 Jul 2019 07:40:21 -0400 Received: from pps.filterd (m0042333.ppops.net [127.0.0.1]) by mx0b-0014ca01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x65Be6JM015222; Fri, 5 Jul 2019 04:40:06 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cadence.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=proofpoint; bh=n712EGstEs78KqPOb2JnDM8Qhzw8IAjFpWH2TroQZIE=; b=tC9GYqHKcR/hiukVfNokNbK7obfR0pdRrUZhuQ6oNnplgElYae5nxU3QkzqjOGTycw61 4dyhjmb37WjQ6XaqJdiGoaDhM2YxizMy5HIalbA7V5MPH7mHYh68dUqudLwASHbF2NEk FXZofAvZS4FQKDGRaFOmJ+80opqYhzECEypgWBvDp+8nRizaNuSjhErEXdlONu0ASd3F rudGqGfdmji6ddFCEpaV3I90rR1slM0VvhIWjEkMUkk3DJ2UYpnUuB3jTnKfjqtl+DZR 20j4ziGDTZ/wpzDpIyAVHNmN24PrEkkIC1ScmzIkFX8ozJKvkH8ileGa38X2MnXpQHKU Bw== Authentication-Results: cadence.com; spf=pass smtp.mailfrom=pawell@cadence.com Received: from nam04-co1-obe.outbound.protection.outlook.com (mail-co1nam04lp2054.outbound.protection.outlook.com [104.47.45.54]) by mx0b-0014ca01.pphosted.com with ESMTP id 2tgwvj86w2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Fri, 05 Jul 2019 04:40:05 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cadence.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=n712EGstEs78KqPOb2JnDM8Qhzw8IAjFpWH2TroQZIE=; b=HxiHoLTJRMmqbuWFnBbTDePFByneLr6pjgKa7Fi9dlMswqXbUXNrMIQTP6ImXuN6pxk3qBQxMgmz9bYeOvV4Qw4Q3zHVeP0r7zfcTSr6GG+IyA+xYPCffgwvpF2keo7pOeGe1eSMUDhNt14zY7QglBAiHlYp4lj4ScAS6QzHytw= Received: from BYAPR07MB4709.namprd07.prod.outlook.com (52.135.204.159) by BYAPR07MB5526.namprd07.prod.outlook.com (20.177.231.148) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2032.20; Fri, 5 Jul 2019 11:39:57 +0000 Received: from BYAPR07MB4709.namprd07.prod.outlook.com ([fe80::fd8c:399c:929b:33e2]) by BYAPR07MB4709.namprd07.prod.outlook.com ([fe80::fd8c:399c:929b:33e2%6]) with mapi id 15.20.2052.010; Fri, 5 Jul 2019 11:39:57 +0000 From: Pawel Laszczak To: Greg KH CC: "devicetree@vger.kernel.org" , "felipe.balbi@linux.intel.com" , "linux-usb@vger.kernel.org" , "hdegoede@redhat.com" , "heikki.krogerus@linux.intel.com" , "robh+dt@kernel.org" , "rogerq@ti.com" , "linux-kernel@vger.kernel.org" , "jbergsagel@ti.com" , "nsekhar@ti.com" , "nm@ti.com" , Suresh Punnoose , "peter.chen@nxp.com" , Jayshri Dajiram Pawar , Rahul Kumar Subject: RE: [PATCH v9 2/6] usb:gadget Separated decoding functions from dwc3 driver. Thread-Topic: [PATCH v9 2/6] usb:gadget Separated decoding functions from dwc3 driver. Thread-Index: AQHVMyB8KL4t/wzfvkK+3nlF+Rqn1Ka74vsAgAAAvUA= Date: Fri, 5 Jul 2019 11:39:57 +0000 Message-ID: References: <1562324238-16655-1-git-send-email-pawell@cadence.com> <1562324238-16655-3-git-send-email-pawell@cadence.com> <20190705112724.GA4294@kroah.com> In-Reply-To: <20190705112724.GA4294@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-dg-ref: PG1ldGE+PGF0IG5tPSJib2R5LnR4dCIgcD0iYzpcdXNlcnNccGF3ZWxsXGFwcGRhdGFccm9hbWluZ1wwOWQ4NDliNi0zMmQzLTRhNDAtODVlZS02Yjg0YmEyOWUzNWJcbXNnc1xtc2ctOWIyYTA1NWMtOWYxOS0xMWU5LTg3NDItMWM0ZDcwMWRmYmE0XGFtZS10ZXN0XDliMmEwNTVkLTlmMTktMTFlOS04NzQyLTFjNGQ3MDFkZmJhNGJvZHkudHh0IiBzej0iMjI1MSIgdD0iMTMyMDY4MDAzOTQ4MjAwNjc3IiBoPSJURlFOMGVaRU1HK1VXM2tkK2JneVBkeHlDTDg9IiBpZD0iIiBibD0iMCIgYm89IjEiLz48L21ldGE+ x-dg-rorf: x-originating-ip: [185.217.253.59] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b3b48998-9ea3-4719-6fd4-08d7013d81bd x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:BYAPR07MB5526; x-ms-traffictypediagnostic: BYAPR07MB5526: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-forefront-prvs: 008960E8EC x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(136003)(396003)(376002)(366004)(346002)(39860400002)(36092001)(189003)(199004)(55016002)(76176011)(99286004)(478600001)(229853002)(7416002)(7696005)(2906002)(316002)(33656002)(66066001)(14454004)(66446008)(73956011)(66946007)(64756008)(76116006)(8936002)(68736007)(66556008)(86362001)(8676002)(52536014)(9686003)(66476007)(81156014)(81166006)(5660300002)(6116002)(3846002)(25786009)(6246003)(256004)(102836004)(71190400001)(71200400001)(26005)(6506007)(486006)(53936002)(186003)(446003)(4326008)(6436002)(54906003)(6916009)(7736002)(74316002)(305945005)(11346002)(476003)(107886003);DIR:OUT;SFP:1101;SCL:1;SRVR:BYAPR07MB5526;H:BYAPR07MB4709.namprd07.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: cadence.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 87NCGEuQYUrK90lX5nYuBBdprm60S7oa8NFhOEe5tRzAwyFjmBc+zEyM5hHW59733gHShNaQhWWuGCnvT5A7Y6g58G+1IpuIbkZ5md5EpdV36d3VZLI0BRM03Ot4w3DSkEQieCN6M973OwRXps8uWy6LMA9NE22aDljZzPpufQLI4gSLf2T+f/awhd11j8IBH32aOxwfGBze/kxqcM/xdsy2G8OpzS2D6V/6DYKbLeX0t8cuk+4xvdhBi/Zqqmyk9tiGSgD4p5RXSfY4IQe0OS6cfIoip0b6+Pksc2juOYfnlqkavRQnloe4OfGqwB9bqZR2IR7jk6TDKtiVz/DQ7A8lE9H7vEQUv4z0H0s35sir5o+do3dinrbVoB3Hz2K+KS25TCadVvTbKVttENYfSmQadlJeGZYk4w5lov3h+Hs= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cadence.com X-MS-Exchange-CrossTenant-Network-Message-Id: b3b48998-9ea3-4719-6fd4-08d7013d81bd X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jul 2019 11:39:57.5654 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pawell@global.cadence.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB5526 X-Proofpoint-SPF-Result: pass X-Proofpoint-SPF-Record: v=spf1 include:spf.smktg.jp include:_spf.salesforce.com include:mktomail.com include:spf-0014ca01.pphosted.com include:spf.protection.outlook.com include:auth.msgapp.com include:spf.mandrillapp.com ~all X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-07-05_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_check_notspam policy=outbound_check score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=873 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1907050141 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org >On Fri, Jul 05, 2019 at 11:57:14AM +0100, Pawel Laszczak wrote: >> Patch moves some decoding functions from driver/usb/dwc3/debug.h driver >> to driver/usb/gadget/debug.c file. These moved functions include: >> dwc3_decode_get_status >> dwc3_decode_set_clear_feature >> dwc3_decode_set_address >> dwc3_decode_get_set_descriptor >> dwc3_decode_get_configuration >> dwc3_decode_set_configuration >> dwc3_decode_get_intf >> dwc3_decode_set_intf >> dwc3_decode_synch_frame >> dwc3_decode_set_sel >> dwc3_decode_set_isoch_delay >> dwc3_decode_ctrl >> >> These functions are used also in inroduced cdns3 driver. >> >> All functions prefixes were changed from dwc3 to usb. >> Also, function's parameters has been extended according to the name >> of fields in standard SETUP packet. >> Additionally, patch adds usb_decode_ctrl function to >> include/linux/usb/gadget.h file. > >No it does not :( I've forgot about this :(=20 It should be include/linux/usb/ch.9.h > >> Signed-off-by: Pawel Laszczak >> --- >> drivers/usb/common/Makefile | 5 + >> drivers/usb/common/debug.c | 268 ++++++++++++++++++++++++++++++++++++ >> drivers/usb/dwc3/debug.h | 252 --------------------------------- >> drivers/usb/dwc3/trace.h | 2 +- >> include/linux/usb/ch9.h | 25 ++++ >> 5 files changed, 299 insertions(+), 253 deletions(-) >> create mode 100644 drivers/usb/common/debug.c >> >> diff --git a/drivers/usb/common/Makefile b/drivers/usb/common/Makefile >> index 0a7c45e85481..cdc66b59a6f0 100644 >> --- a/drivers/usb/common/Makefile >> +++ b/drivers/usb/common/Makefile >> @@ -5,6 +5,11 @@ >> >> obj-$(CONFIG_USB_COMMON) +=3D usb-common.o >> usb-common-y +=3D common.o >> + >> +ifneq ($(CONFIG_TRACING),) >> + usb-common-y +=3D debug.o >> +endif > >So only enable this if tracing is not emabled? Or if enabled? I'm >confused, isn't there an easier way to write this? It's checks if CONFIG_TRACING is enable.=20 It's a common way checking if option is enabled in usb subsystem.=20 > >thanks, > >greg k-h