From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2761DC432BE for ; Thu, 26 Aug 2021 11:09:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 071836109F for ; Thu, 26 Aug 2021 11:09:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241815AbhHZLKU (ORCPT ); Thu, 26 Aug 2021 07:10:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233736AbhHZLKT (ORCPT ); Thu, 26 Aug 2021 07:10:19 -0400 Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [IPv6:2607:f8b0:4864:20::832]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62A79C061757 for ; Thu, 26 Aug 2021 04:09:32 -0700 (PDT) Received: by mail-qt1-x832.google.com with SMTP id t32so2086434qtc.3 for ; Thu, 26 Aug 2021 04:09:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sartura-hr.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UEXF2y6A05AVCBay5D6JPgIFZCILYU47cKg+kBHuhaA=; b=tHgdjDOBKqfSgEkub1fiYL77mW7DT6AKEslDkuo6Kb/uqL7UWN9mmPProiCjWC0Yyz ch+WwK7drAErNNuco6P2ACdeXjqi/I07qACnW6yCSHJWVKCIxQEhM9ZJ9+io8sGrCx5T t9b05BA9bQKDVCgBRu8CrcHVMww/4qa5PV7zefrEBq/+Rk/1Ydq35V/HX1sQkR3zeUrJ kY50BWt9U1Im7KOf7/aUkrlWA9m08EFq0wX4AH5Y2gI+hURQcm45XXPcRQqlOy6TBw4D +3M1sD/HDocOK/pZifwP+yJFWgeOKhFIf9BE2ruem07aLfr93AKR7ikfxhUI4S2OgwN8 bXBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UEXF2y6A05AVCBay5D6JPgIFZCILYU47cKg+kBHuhaA=; b=j4eN7SdUw6CrzNqVP8i19IS88rAUh8+5RE9O8BAgFjwzgMROfj/RGO4JBess0jTLsh FfzKOib9irK7ZAXqamtFaQ1DXEuDTUCVb0aCUvzpTg53Y6QnzsLPCzZ9P4cOkDrRcnMS yw+7VFliRFmJceQoQ/aOd5FFJlbpYjkz3S9Xu4I+oHLS8ro4FR1dhqsTslsY7swrqYBu wmorHPcoCAet90jNNkSrja3YoHAvAA2wE+hu8QzZkvNcfMRCs9mlclGfn1ULxdfwXl86 84/hqQNEAp5oFDzDtdzerHmQ5uTle/UQtMan9WwkA84wEuctL9/YUhLv8YOLvpvgFZ3K Uo9Q== X-Gm-Message-State: AOAM531iYyunUk98ugwDzkWFA+Nc9ix/qwdsUdjC4kL1EVTyBKMIGVZS hTCIrulMiS+LTju5GO4/P7HOITf7oecswQTtnogLcZ402jbD2rkTCb4= X-Google-Smtp-Source: ABdhPJzudFxHMdMyj/n8TBQl4uxcyqxa+OgKlYbhzI+0q03bkJ67zxJp1jm6tKBORWTl8ESR+3J29AgqW024tF2Rz7E= X-Received: by 2002:ac8:5194:: with SMTP id c20mr2653988qtn.68.1629976171603; Thu, 26 Aug 2021 04:09:31 -0700 (PDT) MIME-Version: 1.0 References: <20210826110239.5269-1-robert.marko@sartura.hr> In-Reply-To: From: Robert Marko Date: Thu, 26 Aug 2021 13:09:20 +0200 Message-ID: Subject: Re: [PATCH] USB: serial: pl2303: fix GL type detection To: Johan Hovold Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Thu, Aug 26, 2021 at 1:08 PM Johan Hovold wrote: > > On Thu, Aug 26, 2021 at 01:02:39PM +0200, Robert Marko wrote: > > At least some PL2303GL have a bcdDevice of 0x405 instead of 0x100 as the > > datasheet claims. Add it to the list of known release numbers for the > > HXN (G) type. > > > > Fixes: 894758d0571d ("USB: serial: pl2303: tighten type HXN (G) detection") > > Signed-off-by: Robert Marko > > Thanks for the patch, looks good. > > Could you post the output of lsusb -v for your device as well for > completeness? Sure, here it is: Bus 001 Device 003: ID 067b:23d3 Prolific Technology, Inc. USB-Serial Controller Device Descriptor: bLength 18 bDescriptorType 1 bcdUSB 2.00 bDeviceClass 0 bDeviceSubClass 0 bDeviceProtocol 0 bMaxPacketSize0 64 idVendor 0x067b Prolific Technology, Inc. idProduct 0x23d3 bcdDevice 4.05 iManufacturer 1 Prolific Technology Inc. iProduct 2 USB-Serial Controller iSerial 3 DTBOb106315 bNumConfigurations 1 Configuration Descriptor: bLength 9 bDescriptorType 2 wTotalLength 0x0027 bNumInterfaces 1 bConfigurationValue 1 iConfiguration 0 bmAttributes 0xa0 (Bus Powered) Remote Wakeup MaxPower 100mA Interface Descriptor: bLength 9 bDescriptorType 4 bInterfaceNumber 0 bAlternateSetting 0 bNumEndpoints 3 bInterfaceClass 255 Vendor Specific Class bInterfaceSubClass 0 bInterfaceProtocol 0 iInterface 0 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x81 EP 1 IN bmAttributes 3 Transfer Type Interrupt Synch Type None Usage Type Data wMaxPacketSize 0x000a 1x 10 bytes bInterval 1 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x02 EP 2 OUT bmAttributes 2 Transfer Type Bulk Synch Type None Usage Type Data wMaxPacketSize 0x0040 1x 64 bytes bInterval 0 Endpoint Descriptor: bLength 7 bDescriptorType 5 bEndpointAddress 0x83 EP 3 IN bmAttributes 2 Transfer Type Bulk Synch Type None Usage Type Data wMaxPacketSize 0x0040 1x 64 bytes bInterval 0 Device Status: 0x0000 (Bus Powered) Regards, Robert > > Johan -- Robert Marko Staff Embedded Linux Engineer Sartura Ltd. Lendavska ulica 16a 10000 Zagreb, Croatia Email: robert.marko@sartura.hr Web: www.sartura.hr