From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBD28C47094 for ; Thu, 10 Jun 2021 03:41:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B271C610A7 for ; Thu, 10 Jun 2021 03:41:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230000AbhFJDnK (ORCPT ); Wed, 9 Jun 2021 23:43:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43824 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229655AbhFJDnK (ORCPT ); Wed, 9 Jun 2021 23:43:10 -0400 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED033C06175F for ; Wed, 9 Jun 2021 20:41:02 -0700 (PDT) Received: by mail-pj1-x1029.google.com with SMTP id g4so2841342pjk.0 for ; Wed, 09 Jun 2021 20:41:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=94pKNGw6aDmClK5qtz94uwCrVTPu2QawOX0eEueaQtw=; b=hgdu2EGMeJKw7Zqbcjnq4JgrvciYatqrsvp/Hq38+r3dbFHb3YEZhBI4aQP80VcU84 XTI2zxdzIwKN0fntEi2P4wfCt1Sjc2W6QvJ2Ge6+EzN69HFwWHdVZa7c5odI7eC4fmbY fXfkc4SQl0zDWr1xTXh6Mrc+hVLODwK88TSjU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=94pKNGw6aDmClK5qtz94uwCrVTPu2QawOX0eEueaQtw=; b=VpaUZ4PWACdhh5RjaHJYGqfJK4g8L0fRl3KFhRk3qf7xs5a3dssqqty38Hly7f1tFH vo0UY3/yEPdxuSmKKT6TNV2Hia6XFWZhtodFtcSeafPfgpOfwcRziaOjZ1WETB6tpyPQ Lbid0oKhdpSi+7NbdA30FtHrUo12RAJjWIqZg21Vj/uSSfZcHXe+5+OS++BGW9R8UHSx /PyTvv9nWRUpGpHSN4ttfjIgvnFGqj7FvqOhvH4U+/xeOLhtQo2zk9jWQUu9mZGEPghc rL8bJx7xkIiOu438EnP6jL74q+JZg0rVBpjFNlFkCu3faq2eT1k1zUjmLYob8t8o0S7D +qjA== X-Gm-Message-State: AOAM533rcAL10YYaqGo0lAecCkpbAPiBACUS4fDFG0UvqRMOW5hjFq/O IAoteR5b/VXBBSfFkT3+FRVJowpPf9Eww6lBxN/hzQ== X-Google-Smtp-Source: ABdhPJxfhXQZP1C7d97G/hx7Snn+K2LH9xusJE2FA5qGXcVH1gpUQP62dNOS5MgnxVxXRcpVPneWdOueRi+vrJScXkw= X-Received: by 2002:a17:902:fe83:b029:106:2e:97b6 with SMTP id x3-20020a170902fe83b0290106002e97b6mr2950199plm.49.1623296462349; Wed, 09 Jun 2021 20:41:02 -0700 (PDT) MIME-Version: 1.0 References: <20210507021127.54717-1-chunfeng.yun@mediatek.com> <20210507021127.54717-4-chunfeng.yun@mediatek.com> In-Reply-To: <20210507021127.54717-4-chunfeng.yun@mediatek.com> From: Ikjoon Jang Date: Thu, 10 Jun 2021 11:40:50 +0800 Message-ID: Subject: Re: [PATCH v3 4/4] usb: xhci-mtk: use first-fit for LS/FS To: Chunfeng Yun Cc: Mathias Nyman , Greg Kroah-Hartman , Matthias Brugger , linux-usb@vger.kernel.org, "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , open list , Eddie Hung , Sergei Shtylyov Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Fri, May 7, 2021 at 10:11 AM Chunfeng Yun wrote: > > Use first-fit instead of best-fit for LS/FS devices under TT, > we found that best-fit will consume more bandwidth for some > cases. > > Signed-off-by: Chunfeng Yun Reviewed-and-Tested-by: Ikjoon Jang > --- > v3: no changes > --- > drivers/usb/host/xhci-mtk-sch.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/usb/host/xhci-mtk-sch.c b/drivers/usb/host/xhci-mtk-sch.c > index 9fb75085e40f..c07411d9b16f 100644 > --- a/drivers/usb/host/xhci-mtk-sch.c > +++ b/drivers/usb/host/xhci-mtk-sch.c > @@ -634,6 +634,11 @@ static int check_sch_bw(struct mu3h_sch_bw_info *sch_bw, > min_bw = worst_bw; > min_index = offset; > } > + > + /* use first-fit for LS/FS */ > + if (sch_ep->sch_tt && min_index >= 0) > + break; > + > if (min_bw == 0) > break; > } > -- > 2.18.0 >