From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1BB5C31E40 for ; Mon, 12 Aug 2019 12:05:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9497A20663 for ; Mon, 12 Aug 2019 12:05:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="EgUfNpec" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728029AbfHLMFr (ORCPT ); Mon, 12 Aug 2019 08:05:47 -0400 Received: from mail-pl1-f195.google.com ([209.85.214.195]:34079 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726631AbfHLMFr (ORCPT ); Mon, 12 Aug 2019 08:05:47 -0400 Received: by mail-pl1-f195.google.com with SMTP id i2so47823696plt.1 for ; Mon, 12 Aug 2019 05:05:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PS1QX7iKyx0PhE61EmV9Yna7OuuWh4mhOTj2D+JV0A4=; b=EgUfNpecwcUEljlePNlmURifGcZonf5uXLrgvHbttGCiKGlqIyWlrCvwXt6dMhM6Jy gDXAg6bMroo4fgdS0p/7HtVG8HSGT4M0u/qlJyPzHBOxbZku4dtzbItOQYPsQtT0EpJd 6hJGi2IFYK0W0mPZU1qejGej19lRkcXa7u9kZ6PlFVzw4u2a1Y1YOB6K9eJCpALB9Hc0 AZuSNFafJ0GT8pOMlsSfOzQUR0ml4ugbHR8E9lDXvs3JhHjDANCsGYdXteuKlHwfWigN DQahy23gXTBvZ+UgxT7SgU3I8uxfCC9T+Nl7QarlzuXVbOylwJ2k2a0/5U4WMAyQ7KCy NKUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PS1QX7iKyx0PhE61EmV9Yna7OuuWh4mhOTj2D+JV0A4=; b=Dm5+hrJGZaFdK6/TYrSCfM1g26/wvhwIAQ/8vaP1ghqihO8B7HNyOofxBCezBCEaJV VgeNbjt/0Vrhve96mO8CMpY7vuXRiFT//EIl+nYZKCvo9dWNQfcyL5/gTSiRKI9hxP0K zDP0ttVATZyJ9Of6xKhgkCI7dBdlaiVc4SH1gC8Edl+gYvc7EP8f4U7OnSG3/lkzkTyL mPKjynd6rOaZ3ySxAPMMYJtqRPy6AYzgCjkBR0bIPyprLw0wlr88hf20ZCpZ3DA3TKq2 GUckRt6CoN/oRBm7Mrm+TdGYSE5QNFjZlT3rSpKQQ0dsOJvAb52lVs/eyfOEhJ/Ep2ZM 0msw== X-Gm-Message-State: APjAAAWesuPgNEkCaFzX13MEljOViKbG5Xx0rJk3X13m3qR1R3e/eE9s oMOM58wL7d8lRpyWorFL579AF1ThQjl2kBWA17HXy9BqwP5d3w== X-Google-Smtp-Source: APXvYqxooOEIFr7cgeYHUa4q2pJCIIvwnE+2awsYT0GDGuW1kipVJPmuPXYGxSjagz7WzIHCrJMUuX2VPTojuB9PfB8= X-Received: by 2002:a17:902:8649:: with SMTP id y9mr5345375plt.252.1565611546212; Mon, 12 Aug 2019 05:05:46 -0700 (PDT) MIME-Version: 1.0 References: <000000000000502536058faf0113@google.com> In-Reply-To: <000000000000502536058faf0113@google.com> From: Andrey Konovalov Date: Mon, 12 Aug 2019 14:05:34 +0200 Message-ID: Subject: Re: KASAN: use-after-free Read in prepare_to_wait_event To: syzbot Cc: alexandre.belloni@bootlin.com, enric.balletbo@collabora.com, Greg Kroah-Hartman , kirr@nexedi.com, LKML , USB list , Guenter Roeck , logang@deltatee.com, syzkaller-bugs Content-Type: text/plain; charset="UTF-8" Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Fri, Aug 9, 2019 at 3:18 PM syzbot wrote: > > Hello, > > syzbot found the following crash on: > > HEAD commit: e96407b4 usb-fuzzer: main usb gadget fuzzer driver > git tree: https://github.com/google/kasan.git usb-fuzzer > console output: https://syzkaller.appspot.com/x/log.txt?x=10fbde8c600000 > kernel config: https://syzkaller.appspot.com/x/.config?x=cfa2c18fb6a8068e > dashboard link: https://syzkaller.appspot.com/bug?extid=332cbcbd8be3e03c62eb > compiler: gcc (GCC) 9.0.0 20181231 (experimental) > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=127dd636600000 > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=171de9ce600000 > > IMPORTANT: if you fix the bug, please add the following tag to the commit: > Reported-by: syzbot+332cbcbd8be3e03c62eb@syzkaller.appspotmail.com > > ================================================================== > BUG: KASAN: use-after-free in __lock_acquire+0x302a/0x3b50 > kernel/locking/lockdep.c:3753 > Read of size 8 at addr ffff8881d2a83238 by task syz-executor771/2979 > > CPU: 0 PID: 2979 Comm: syz-executor771 Not tainted 5.3.0-rc2+ #25 > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS > Google 01/01/2011 > Call Trace: > __dump_stack lib/dump_stack.c:77 [inline] > dump_stack+0xca/0x13e lib/dump_stack.c:113 > print_address_description+0x6a/0x32c mm/kasan/report.c:351 > __kasan_report.cold+0x1a/0x33 mm/kasan/report.c:482 > kasan_report+0xe/0x12 mm/kasan/common.c:612 > __lock_acquire+0x302a/0x3b50 kernel/locking/lockdep.c:3753 > lock_acquire+0x127/0x320 kernel/locking/lockdep.c:4412 > __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline] > _raw_spin_lock_irqsave+0x32/0x50 kernel/locking/spinlock.c:159 > prepare_to_wait_event+0x5b/0x650 kernel/sched/wait.c:263 > ld_usb_read+0x619/0x780 drivers/usb/misc/ldusb.c:480 #syz dup: KASAN: use-after-free Read in ld_usb_release > __vfs_read+0x76/0x100 fs/read_write.c:425 > vfs_read+0x1ea/0x430 fs/read_write.c:461 > ksys_read+0x1e8/0x250 fs/read_write.c:587 > do_syscall_64+0xb7/0x580 arch/x86/entry/common.c:296 > entry_SYSCALL_64_after_hwframe+0x49/0xbe > RIP: 0033:0x448859 > Code: e8 ac e7 ff ff 48 83 c4 18 c3 0f 1f 80 00 00 00 00 48 89 f8 48 89 f7 > 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff > ff 0f 83 4b 06 fc ff c3 66 2e 0f 1f 84 00 00 00 00 > RSP: 002b:00007f9b31740ce8 EFLAGS: 00000246 ORIG_RAX: 0000000000000000 > RAX: ffffffffffffffda RBX: 00000000006dec48 RCX: 0000000000448859 > RDX: 0000000000000049 RSI: 0000000020000080 RDI: 0000000000000004 > RBP: 00000000006dec40 R08: 0000000000000000 R09: 0000000000000000 > R10: 0000000000000000 R11: 0000000000000246 R12: 00000000006dec4c > R13: 00007ffd58e161df R14: 00007f9b317419c0 R15: 00000000006dec4c > > Allocated by task 2705: > save_stack+0x1b/0x80 mm/kasan/common.c:69 > set_track mm/kasan/common.c:77 [inline] > __kasan_kmalloc mm/kasan/common.c:487 [inline] > __kasan_kmalloc.constprop.0+0xbf/0xd0 mm/kasan/common.c:460 > kmalloc include/linux/slab.h:552 [inline] > kzalloc include/linux/slab.h:748 [inline] > ld_usb_probe+0x6e/0xa65 drivers/usb/misc/ldusb.c:661 > usb_probe_interface+0x305/0x7a0 drivers/usb/core/driver.c:361 > really_probe+0x281/0x650 drivers/base/dd.c:548 > driver_probe_device+0x101/0x1b0 drivers/base/dd.c:709 > __device_attach_driver+0x1c2/0x220 drivers/base/dd.c:816 > bus_for_each_drv+0x15c/0x1e0 drivers/base/bus.c:454 > __device_attach+0x217/0x360 drivers/base/dd.c:882 > bus_probe_device+0x1e4/0x290 drivers/base/bus.c:514 > device_add+0xae6/0x16f0 drivers/base/core.c:2114 > usb_set_configuration+0xdf6/0x1670 drivers/usb/core/message.c:2023 > generic_probe+0x9d/0xd5 drivers/usb/core/generic.c:210 > usb_probe_device+0x99/0x100 drivers/usb/core/driver.c:266 > really_probe+0x281/0x650 drivers/base/dd.c:548 > driver_probe_device+0x101/0x1b0 drivers/base/dd.c:709 > __device_attach_driver+0x1c2/0x220 drivers/base/dd.c:816 > bus_for_each_drv+0x15c/0x1e0 drivers/base/bus.c:454 > __device_attach+0x217/0x360 drivers/base/dd.c:882 > bus_probe_device+0x1e4/0x290 drivers/base/bus.c:514 > device_add+0xae6/0x16f0 drivers/base/core.c:2114 > usb_new_device.cold+0x6a4/0xe79 drivers/usb/core/hub.c:2536 > hub_port_connect drivers/usb/core/hub.c:5098 [inline] > hub_port_connect_change drivers/usb/core/hub.c:5213 [inline] > port_event drivers/usb/core/hub.c:5359 [inline] > hub_event+0x1b5c/0x3640 drivers/usb/core/hub.c:5441 > process_one_work+0x92b/0x1530 kernel/workqueue.c:2269 > worker_thread+0x96/0xe20 kernel/workqueue.c:2415 > kthread+0x318/0x420 kernel/kthread.c:255 > ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352 > > Freed by task 2705: > save_stack+0x1b/0x80 mm/kasan/common.c:69 > set_track mm/kasan/common.c:77 [inline] > __kasan_slab_free+0x130/0x180 mm/kasan/common.c:449 > slab_free_hook mm/slub.c:1423 [inline] > slab_free_freelist_hook mm/slub.c:1470 [inline] > slab_free mm/slub.c:3012 [inline] > kfree+0xe4/0x2f0 mm/slub.c:3953 > ld_usb_probe+0x728/0xa65 drivers/usb/misc/ldusb.c:744 > usb_probe_interface+0x305/0x7a0 drivers/usb/core/driver.c:361 > really_probe+0x281/0x650 drivers/base/dd.c:548 > driver_probe_device+0x101/0x1b0 drivers/base/dd.c:709 > __device_attach_driver+0x1c2/0x220 drivers/base/dd.c:816 > bus_for_each_drv+0x15c/0x1e0 drivers/base/bus.c:454 > __device_attach+0x217/0x360 drivers/base/dd.c:882 > bus_probe_device+0x1e4/0x290 drivers/base/bus.c:514 > device_add+0xae6/0x16f0 drivers/base/core.c:2114 > usb_set_configuration+0xdf6/0x1670 drivers/usb/core/message.c:2023 > generic_probe+0x9d/0xd5 drivers/usb/core/generic.c:210 > usb_probe_device+0x99/0x100 drivers/usb/core/driver.c:266 > really_probe+0x281/0x650 drivers/base/dd.c:548 > driver_probe_device+0x101/0x1b0 drivers/base/dd.c:709 > __device_attach_driver+0x1c2/0x220 drivers/base/dd.c:816 > bus_for_each_drv+0x15c/0x1e0 drivers/base/bus.c:454 > __device_attach+0x217/0x360 drivers/base/dd.c:882 > bus_probe_device+0x1e4/0x290 drivers/base/bus.c:514 > device_add+0xae6/0x16f0 drivers/base/core.c:2114 > usb_new_device.cold+0x6a4/0xe79 drivers/usb/core/hub.c:2536 > hub_port_connect drivers/usb/core/hub.c:5098 [inline] > hub_port_connect_change drivers/usb/core/hub.c:5213 [inline] > port_event drivers/usb/core/hub.c:5359 [inline] > hub_event+0x1b5c/0x3640 drivers/usb/core/hub.c:5441 > process_one_work+0x92b/0x1530 kernel/workqueue.c:2269 > worker_thread+0x96/0xe20 kernel/workqueue.c:2415 > kthread+0x318/0x420 kernel/kthread.c:255 > ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352 > > The buggy address belongs to the object at ffff8881d2a83180 > which belongs to the cache kmalloc-512 of size 512 > The buggy address is located 184 bytes inside of > 512-byte region [ffff8881d2a83180, ffff8881d2a83380) > The buggy address belongs to the page: > page:ffffea00074aa080 refcount:1 mapcount:0 mapping:ffff8881da002500 > index:0x0 compound_mapcount: 0 > flags: 0x200000000010200(slab|head) > raw: 0200000000010200 dead000000000100 dead000000000122 ffff8881da002500 > raw: 0000000000000000 00000000000c000c 00000001ffffffff 0000000000000000 > page dumped because: kasan: bad access detected > > Memory state around the buggy address: > ffff8881d2a83100: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc > ffff8881d2a83180: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb > > ffff8881d2a83200: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb > ^ > ffff8881d2a83280: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb > ffff8881d2a83300: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb > ================================================================== > > > --- > This bug is generated by a bot. It may contain errors. > See https://goo.gl/tpsmEJ for more information about syzbot. > syzbot engineers can be reached at syzkaller@googlegroups.com. > > syzbot will keep track of this bug report. See: > https://goo.gl/tpsmEJ#status for how to communicate with syzbot. > syzbot can test patches for this bug, for details see: > https://goo.gl/tpsmEJ#testing-patches