From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23966C388F7 for ; Fri, 13 Nov 2020 12:51:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B4FC320A8B for ; Fri, 13 Nov 2020 12:51:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="dwLawQ2R" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726411AbgKMMvc (ORCPT ); Fri, 13 Nov 2020 07:51:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726176AbgKMMvb (ORCPT ); Fri, 13 Nov 2020 07:51:31 -0500 Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F31EAC0617A6 for ; Fri, 13 Nov 2020 04:51:30 -0800 (PST) Received: by mail-pg1-x541.google.com with SMTP id e21so6994132pgr.11 for ; Fri, 13 Nov 2020 04:51:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RlSweQC/vbr6vVyH3NIdsAt2yYJjWCSYyoY0OD4IcB8=; b=dwLawQ2R+OOwSH39oYEUA0iMfpYt3lw8v8lDpkj5TykedwuvLf/Qztt0VfKGbkAEEB Gznivr2/m060TEu3G24XrivgpxgsG0uQzwkIGZu6Eu7mmZuNUMVsuIKXwGxVQIqkG98J l6roqTW+fSOCMqmiCgpGo2JgL0HfMLv8p8sK+n+ZlIuckzq9xCHMMmc87ZRU/GpdP95T msLeaiSIaEtj7dLOEPmxl8xtpejQBB6Vgn9kB1jHPrTznciwzJjR4H7om7sc9sptmrvz T1b6gqZlKU3cqJ/5/PdIeD4MeJbb6xsRAu69CupSSrEd+BaDocLySEyud/Lv97wiHyZM /bbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RlSweQC/vbr6vVyH3NIdsAt2yYJjWCSYyoY0OD4IcB8=; b=WxhSqRHkrs3jOy0mNACSErI7QdAvLUs28lbtLD6bJmsaDlZu9mPehclz2vQRpyhlEA yFTKTr6PYOinm/DExDnIwdWmNlNlDn7vEfo9V7TOzzB6WCKXE2buNQVp0KOW2Pw6vCSq sCd7zFcns/COr8CKv524xzYDvL2kSB3fkSI+mCLKEoyEej1SHN+yV82Azyx389W/QU4/ EUAW669hESXYn8Xjpryk50L2vv74ZFUk290PcwQlAz620iP5rHwTVi6KQBBOM7glgr5z f7oysUjEiOfRqcr2iXShblckD0kX7ycaYZ2h2FCaTjo5kPseXNP7M/r90KupkFhimZus HGTA== X-Gm-Message-State: AOAM532QQe+1pde5alLd0fDo8xU6kbD16Fv+3H0so1vmwsSlKg94U3Pn 2xrtVX79OU5Xxate8+3+N0Y4wub7R4ToIXyLY/q9PorL/x4= X-Google-Smtp-Source: ABdhPJwlHODXN1Li2PDm3D3teyG41NzlM71F1W15YU+kTJo10kkqtHjKM1w5zGh+JoDND4NYH/NRz+Gu59EF7AM/AlM= X-Received: by 2002:a17:90b:300b:: with SMTP id hg11mr1217625pjb.41.1605271890393; Fri, 13 Nov 2020 04:51:30 -0800 (PST) MIME-Version: 1.0 References: <20201113123035.tjllvijjzd54npsf@linutronix.de> In-Reply-To: <20201113123035.tjllvijjzd54npsf@linutronix.de> From: Andrey Konovalov Date: Fri, 13 Nov 2020 13:51:19 +0100 Message-ID: Subject: Re: [PATCH v4] kcov, usb: only collect coverage from __usb_hcd_giveback_urb in softirq To: Sebastian Andrzej Siewior Cc: Dmitry Vyukov , Greg Kroah-Hartman , USB list , LKML , Andrew Morton , Alan Stern , Shuah Khan , Alexander Potapenko , Marco Elver , Aleksandr Nogikh , Nazime Hande Harputluoglu , Thomas Gleixner Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Fri, Nov 13, 2020 at 1:30 PM Sebastian Andrzej Siewior wrote: > > On 2020-10-16 15:57:45 [+0200], Andrey Konovalov wrote: > > --- a/drivers/usb/core/hcd.c > > +++ b/drivers/usb/core/hcd.c > > @@ -1646,9 +1646,16 @@ static void __usb_hcd_giveback_urb(struct urb *urb) > > > > /* pass ownership to the completion handler */ > > urb->status = status; > > - kcov_remote_start_usb((u64)urb->dev->bus->busnum); > > + /* > > + * This function can be called in task context inside another remote > > + * coverage collection section, but KCOV doesn't support that kind of > > + * recursion yet. Only collect coverage in softirq context for now. > > + */ > > + if (in_serving_softirq()) > > Could this in_serving_softirq() usage be replaced, please? Hi Sebastian, Replaced with what and why? Thanks!