Linux-USB Archive on lore.kernel.org
 help / color / Atom feed
From: Aidan Thornton <makosoft@gmail.com>
To: Oliver Neukum <oneukum@suse.com>
Cc: Marco Zatta <marco@zatta.me>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Linux USB Mailing List <linux-usb@vger.kernel.org>
Subject: Re: [PATCH] Fix chipmunk-like voice when using Logitech C270 for recording audio.
Date: Thu, 20 Jun 2019 21:19:46 +0100
Message-ID: <CAB=c7ToV==vGZWOXaRqRcoOb4TNeVqi4QNAvgtiN0K6JjoF8Tg@mail.gmail.com> (raw)
In-Reply-To: <1559555890.25071.5.camel@suse.com>

On Mon, Jun 3, 2019 at 12:46 PM Oliver Neukum <oneukum@suse.com> wrote:
>
> Am Samstag, den 01.06.2019, 09:52 +0200 schrieb Marco Zatta:
> > This patch fixes the chipmunk-like voice that manifets randomly when
> > using the integrated mic of the Logitech Webcam HD C270.
> >
> > The issue was solved initially for this device by commit
> > 2394d67e446bf616a0885167d5f0d397bdacfdfc but it was then reintroduced by
> > e387ef5c47ddeaeaa3cbdc54424cdb7a28dae2c0. This patch is to have the fix
> > back.
>
> Are you sure only the C270 is affected?

I can unfortunately confirm that it doesn't just seem to be the C270.
I've been having the same problem with my Logitech Webcam Pro 9000
which was one of the models that 2394d67e446b applied the RESET_RESUME
quirk to, and adding it to the quirks list appears to have solved the
problem.

This doesn't make much sense though. e387ef5c47dd should apply this
quirk to all Logitech UVC webcams, and this is definitely a UVC-based
Logitech webcam with the appropriate VID and interface descriptor.
Surely it shouldn't make any difference whether I add an entry for the
specific VID+PID pair of my particular camera or not? The C270 is as
well, I think.

What's particularly annoying is that since this is an intermittent
problem, it's hard to tell if I'm chasing a phantom solution for it
again. Haven't managed to replicate it since applying this fix and did
so pretty quickly before but you never know.

  parent reply index

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-01  7:52 Marco Zatta
2019-06-01  9:33 ` Sergei Shtylyov
2019-06-01 10:11   ` Marco Zatta
2019-06-01 11:45     ` Greg KH
2019-06-03  9:58 ` Oliver Neukum
2019-06-03 17:55   ` Marco Zatta
2019-06-04  9:14     ` Oliver Neukum
2019-06-05  9:30       ` Greg Kroah-Hartman
2019-06-20 20:19   ` Aidan Thornton [this message]
2019-07-02 12:46     ` Oliver Neukum
2019-07-02 13:25       ` Greg Kroah-Hartman
2019-07-03 13:54     ` Oliver Neukum

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAB=c7ToV==vGZWOXaRqRcoOb4TNeVqi4QNAvgtiN0K6JjoF8Tg@mail.gmail.com' \
    --to=makosoft@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=marco@zatta.me \
    --cc=oneukum@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-USB Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-usb/0 linux-usb/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-usb linux-usb/ https://lore.kernel.org/linux-usb \
		linux-usb@vger.kernel.org linux-usb@archiver.kernel.org
	public-inbox-index linux-usb


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-usb


AGPL code for this site: git clone https://public-inbox.org/ public-inbox