From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B8F4C433E0 for ; Thu, 25 Mar 2021 09:24:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AB469619E4 for ; Thu, 25 Mar 2021 09:24:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229888AbhCYJXj (ORCPT ); Thu, 25 Mar 2021 05:23:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229898AbhCYJXZ (ORCPT ); Thu, 25 Mar 2021 05:23:25 -0400 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A3F4C06175F for ; Thu, 25 Mar 2021 02:23:21 -0700 (PDT) Received: by mail-lf1-x12f.google.com with SMTP id g8so1448355lfv.12 for ; Thu, 25 Mar 2021 02:23:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5tvrHzTq0gWQPCywVaxzy6v7kow1O87LeytCB1bodgo=; b=MhuB3SGDVQsjhET84L/1KRiomBF9a3KFIb9j4QcSXe84rt6vYQxQM2JztojeCFrrZb UbRU5kqkkkm+M2wKA2l6ha4Su6XNphRWO15O8wdYL1B5OugaXK71kTkTO45qIjS4CZ5F vrAIecz7SBCbLrInmd8qex7TU2WdOqcYo2UCPV9Ti56O0gzSiN4TvKNywMThXCW8m7lc 58zXYjS3v5MjF8Iwi0CP9ZlJDYxCxPOk8u37pslrBPpCfbA/AC2gkIuojPJhdvdmuoRX kBuKPr8T6zCs9195GUMZ1iYBj7x9ZTf7Z/q7tJQkFlMsbfAubCnJ5e8n65t6Z+4Dr320 j9EA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5tvrHzTq0gWQPCywVaxzy6v7kow1O87LeytCB1bodgo=; b=d3fR98QyI0mo6SHfuq8cAgW5D00Ch3mqg+pyYeLJlBhsjRgdGa2/XwfKeim4XgX8Tg SBeG82lxo7ruQ/jKXzAIugT+8amgem8NrqCDQWNQTGJa+zg+rD7uKbUEgc0qmYm7+SRQ 9OqCwGT772v9PGovvHIzZP9y83eOCtgY6y8dVxA9sxWk0fDJ0n6Gyeoq0fovkyfPxn49 bg/9IEdch9+0UV+PuSYEpaGQGxDhEhhgC/j6TqZq3WSsrC0IqQ42+FhYWPMzG0m8/U0h vT/ncVwjakuCO2FjoA6eG/NFg3X57Ri5mLOiYCcD9gB19sbpdOAbMT5nxGeVvvfanpso jsWg== X-Gm-Message-State: AOAM5312kAVejF8lexw/P+kNR/skjK3EcmTn1jwev9xcoeO1DNcWykJ2 ZjDebFjtLHy7jODzgVq5TxCaTw9rEtvhoVzJLtRpgA== X-Google-Smtp-Source: ABdhPJxZ9tJzr5Ma99P00E4TPr2rgQatQ4a9hwr5E8JzXVY8NxG2acO+Rt8Upz77y2AfiiaXQ3/mGz5FXGWZKXowQ2o= X-Received: by 2002:a05:6512:243:: with SMTP id b3mr4569222lfo.529.1616664199644; Thu, 25 Mar 2021 02:23:19 -0700 (PDT) MIME-Version: 1.0 References: <20210323153626.54908-1-andriy.shevchenko@linux.intel.com> <20210323153626.54908-6-andriy.shevchenko@linux.intel.com> In-Reply-To: <20210323153626.54908-6-andriy.shevchenko@linux.intel.com> From: Linus Walleij Date: Thu, 25 Mar 2021 10:23:08 +0100 Message-ID: Subject: Re: [PATCH v2 6/7] usb: gadget: pch_udc: Initialize device pointer before use To: Andy Shevchenko Cc: linux-usb , "linux-kernel@vger.kernel.org" , Felipe Balbi , Greg Kroah-Hartman Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Tue, Mar 23, 2021 at 4:36 PM Andy Shevchenko wrote: > During conversion to use GPIO descriptors the device pointer, > which is applied to devm_gpiod_get(), is not yet initialized. > > Move initialization in the ->probe() in order to have it set before use. > > Fixes: e20849a8c883 ("usb: gadget: pch_udc: Convert to use GPIO descriptors") > Signed-off-by: Andy Shevchenko Ooops sorry. Reviewed-by: Linus Walleij Yours, Linus Walleij