From: Dmitry Vyukov <dvyukov@google.com>
To: Andrey Konovalov <andreyknvl@google.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>,
Andrew Morton <akpm@linux-foundation.org>,
USB list <linux-usb@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Alexander Potapenko <glider@google.com>,
Marco Elver <elver@google.com>
Subject: Re: [PATCH v4 4/7] kcov: move t->kcov_sequence assignment
Date: Thu, 4 Jun 2020 15:07:11 +0200 [thread overview]
Message-ID: <CACT4Y+ZR0FvQeRvfsTpwUMQ8gFfMT4BKPt79PdTN-_HCN8pdAw@mail.gmail.com> (raw)
In-Reply-To: <5889efe35e0b300e69dba97216b1288d9c2428a8.1585233617.git.andreyknvl@google.com>
On Thu, Mar 26, 2020 at 3:44 PM Andrey Konovalov <andreyknvl@google.com> wrote:
>
> Move t->kcov_sequence assignment before assigning t->kcov_mode
> for consistency.
>
> Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
Reviewed-by: Dmitry Vyukov <dvyukov@google.com>
> ---
> kernel/kcov.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/kcov.c b/kernel/kcov.c
> index 888d0a236b04..b985b7a72870 100644
> --- a/kernel/kcov.c
> +++ b/kernel/kcov.c
> @@ -318,10 +318,10 @@ static void kcov_start(struct task_struct *t, struct kcov *kcov,
> /* Cache in task struct for performance. */
> t->kcov_size = size;
> t->kcov_area = area;
> + t->kcov_sequence = sequence;
> /* See comment in check_kcov_mode(). */
> barrier();
> WRITE_ONCE(t->kcov_mode, mode);
> - t->kcov_sequence = sequence;
> }
>
> static void kcov_stop(struct task_struct *t)
> --
> 2.26.0.rc2.310.g2932bb562d-goog
>
next prev parent reply other threads:[~2020-06-04 13:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 14:43 [PATCH v4 0/7] kcov: collect coverage from usb soft interrupts Andrey Konovalov
2020-03-26 14:44 ` [PATCH v4 1/7] kcov: cleanup debug messages Andrey Konovalov
2020-06-04 12:05 ` Dmitry Vyukov
2020-03-26 14:44 ` [PATCH v4 2/7] kcov: fix potential use-after-free in kcov_remote_start Andrey Konovalov
2020-06-04 12:06 ` Dmitry Vyukov
2020-03-26 14:44 ` [PATCH v4 3/7] kcov: move t->kcov assignments into kcov_start/stop Andrey Konovalov
2020-06-04 12:09 ` Dmitry Vyukov
2020-03-26 14:44 ` [PATCH v4 4/7] kcov: move t->kcov_sequence assignment Andrey Konovalov
2020-06-04 13:07 ` Dmitry Vyukov [this message]
2020-03-26 14:44 ` [PATCH v4 5/7] kcov: use t->kcov_mode as enabled indicator Andrey Konovalov
2020-06-04 13:07 ` Dmitry Vyukov
2020-03-26 14:44 ` [PATCH v4 6/7] kcov: collect coverage from interrupts Andrey Konovalov
2020-06-04 13:11 ` Dmitry Vyukov
2020-03-26 14:44 ` [PATCH v4 7/7] usb: core: kcov: collect coverage from usb complete callback Andrey Konovalov
2020-06-04 13:12 ` Dmitry Vyukov
2020-06-04 13:46 ` [PATCH v4 0/7] kcov: collect coverage from usb soft interrupts Andrey Konovalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACT4Y+ZR0FvQeRvfsTpwUMQ8gFfMT4BKPt79PdTN-_HCN8pdAw@mail.gmail.com \
--to=dvyukov@google.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).