From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AD47C33CB2 for ; Tue, 14 Jan 2020 07:51:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 61ACD217BA for ; Tue, 14 Jan 2020 07:51:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="WZsk/3S9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728901AbgANHvz (ORCPT ); Tue, 14 Jan 2020 02:51:55 -0500 Received: from mail-qt1-f193.google.com ([209.85.160.193]:37868 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728682AbgANHvz (ORCPT ); Tue, 14 Jan 2020 02:51:55 -0500 Received: by mail-qt1-f193.google.com with SMTP id w47so11672618qtk.4 for ; Mon, 13 Jan 2020 23:51:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rhT+e3kmyPDqgmQXDlJ4XsnZWAFBKtN4akZdNapdz4g=; b=WZsk/3S904U6Amhzam+HkGVGpD9ofxhA0809RiDrT4fVh1PaMXFYcK96PQcfeyPXZl FlPKJH9jlqc5Ygh1B+1E3BbPSYyZiE9w4na87cGBZfI0kChGFZNae2WE61YWxiuqQeTN zuAGmr5K/3zvgCUsMOh1QPxfKAKIsTYj2kOwg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rhT+e3kmyPDqgmQXDlJ4XsnZWAFBKtN4akZdNapdz4g=; b=oULx0EITQ1/QQDRHOlnJ1PMhpGFpgwDkmnhTS0D+wIFqhMra6FgEVDBVkbRMbYVzlK Lq1P/smZ8B9xJurOqf+LtDnuZLPyqyHYFd0+jJQ1J1FS6vhvPMgrMytF9s1K8h4Fn62S z4JYewFBYt3JhIwpPO6AQ5tzCOk7N7Kdk3D7CEcuHPWpy38FP6KoDfhYzZL0rrx1kFpj llUzeR2siVeqHm0H7A0xfKRrOAXUco/r9ZeP0uCvBVffXKw6v6o93epfOy8Shtdo3hYP K0cAI5KpvIL95BB7YncetEOU58zMPe3dhl/lhJ4CHcVG1qxNxShl8sInGXKZg6HpFbmi oYkg== X-Gm-Message-State: APjAAAXGtmCvhJieh4uJU0oaC2z9bEkyxWP8v58PrkzJTkFBJzlnsmEi 1Ste9T8/ssiRQ0TSWZ6ucuu5Gcl0Y5xE9GncLrYXSA== X-Google-Smtp-Source: APXvYqwhQYF/GKLD9HKWK24cEOdmxhckIK4Lacr+f3TBQEpZsO2ajEnxpItfNVrVcpPo1oY6aK0PPcZ8WZLG9FomFVA= X-Received: by 2002:aed:29e1:: with SMTP id o88mr2577201qtd.182.1578988313958; Mon, 13 Jan 2020 23:51:53 -0800 (PST) MIME-Version: 1.0 References: <20200114044127.20085-1-kai.heng.feng@canonical.com> In-Reply-To: <20200114044127.20085-1-kai.heng.feng@canonical.com> From: Prashant Malani Date: Mon, 13 Jan 2020 23:51:42 -0800 Message-ID: Subject: Re: [PATCH] r8152: Add MAC passthrough support to new device To: Kai-Heng Feng Cc: David Miller , Hayes Wang , Jakub Kicinski , Grant Grundler , Mario Limonciello , David Chen , "open list:USB NETWORKING DRIVERS" , "open list:NETWORKING DRIVERS" , open list Content-Type: text/plain; charset="UTF-8" Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Mon, Jan 13, 2020 at 8:41 PM Kai-Heng Feng wrote: > > Device 0xa387 also supports MAC passthrough, therefore add it to the > whitelst. > > BugLink: https://bugs.launchpad.net/bugs/1827961/comments/30 > Signed-off-by: Kai-Heng Feng > --- > drivers/net/usb/r8152.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c > index c5ebf35d2488..42dcf1442cc0 100644 > --- a/drivers/net/usb/r8152.c > +++ b/drivers/net/usb/r8152.c > @@ -6657,7 +6657,8 @@ static int rtl8152_probe(struct usb_interface *intf, > } > > if (le16_to_cpu(udev->descriptor.idVendor) == VENDOR_ID_LENOVO && > - le16_to_cpu(udev->descriptor.idProduct) == 0x3082) > + (le16_to_cpu(udev->descriptor.idProduct) == 0x3082 || > + le16_to_cpu(udev->descriptor.idProduct) == 0xa387)) Perhaps we can try to use #define's for these vendor IDs (like https://github.com/torvalds/linux/blob/master/drivers/net/usb/r8152.c#L680) ? > set_bit(LENOVO_MACPASSTHRU, &tp->flags); > > if (le16_to_cpu(udev->descriptor.bcdDevice) == 0x3011 && udev->serial && > -- > 2.17.1 >