linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Prashant Malani <pmalani@chromium.org>
To: Mathias Nyman <mathias.nyman@linux.intel.com>
Cc: Bernhard Gebetsberger <bernhard.gebetsberger@gmx.at>,
	linux-usb@vger.kernel.org, Hayes Wang <hayeswang@realtek.com>,
	Grant Grundler <grundler@chromium.org>
Subject: Re: Regression: USB/xhci issues on some systems with newer kernel versions
Date: Fri, 3 Jan 2020 16:58:25 -0800	[thread overview]
Message-ID: <CACeCKaeoPER7wmE7uj-R0a=8eRC64TpRcP0=bg=mvtx7h72DfQ@mail.gmail.com> (raw)
In-Reply-To: <06beef2f-e1e1-a95e-87d2-597566d1edd3@linux.intel.com>

Hi Mathias

On Mon, Dec 16, 2019 at 5:27 AM Mathias Nyman
<mathias.nyman@linux.intel.com> wrote:
>
> Hi Prashant
>
> On 5.12.2019 22.34, Prashant Malani wrote:
> > Hi Mathias and Bernhard,
> >
> > I was interested in knowing if this issue was resolved (sounded like
> > this was deemed to be a hardware error, but I'm not sure).
> > The reason I ask is that we've recently noticed a similar error
> > popping up while using Realtek rtl8153a-based ethernet USB dongles
> > (these use the r8152 driver) on kernel 4.19 :
> > " hci_hcd 0000:00:14.0: WARN Set TR Deq Ptr cmd failed due to
> > incorrect slot or ep state."
> > This is generally followed by the dongle getting reset, and the
> > process repeats itself continuously.
>
> Sorry about the delay, your traces show a transaction error, and the port link
> going to inactive error state.
>
> xhci driver tries to recover from the transaction error with a soft retry
> (endpoint reset), while hub thread will need to reset the whole device to recover
> from the inactive link error state.
>
> Can you try reverting commit:
> "f8f80be501aa xhci: Use soft retry to recover faster from transaction errors"
>
> If you still see "Transfer error for slot x ep y on endpoint" in dmesg,
> but device is not reset and works normally, then it's possible that the soft retry
> makes things worse.

Thanks for your analysis, and sorry for the delayed response. I
reverted the aforementioned commit. While the transfer error no longer
appears, I still see the repeated resets, so there is likely an issue
either on the Host Controller, or the device firmware itself.
I'll continue digging, but seems safe to rule out soft retry as a culprit.

Best regards,
>
> If not, then the transaction error and the link inactive error are most likely symptoms
> of some other cause.
>
> The hci_hcd 0000:00:14.0: WARN Set TR Deq Ptr cmd failed due to incorrect slot or ep state."
> is as in Bernhard's case due to xhci driver trying to issue a command for a slot in context error
> state, this part needs to be fixed in the driver, but should not matter much. Device must be reset
> anyway to recover from the link inactive error state.
>
> -Mathias
>

      reply	other threads:[~2020-01-04  0:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-02 12:28 Regression: USB/xhci issues on some systems with newer kernel versions Bernhard Gebetsberger
2019-10-03 10:23 ` Mathias Nyman
2019-10-03 15:13   ` Bernhard Gebetsberger
2019-10-11  1:55     ` Bernhard Gebetsberger
2019-10-14 13:03     ` Mathias Nyman
2019-12-05 20:34       ` Prashant Malani
2019-12-05 22:49         ` Prashant Malani
2019-12-05 23:19         ` Bernhard Gebetsberger
2019-12-05 23:23           ` Prashant Malani
2019-12-16 13:29         ` Mathias Nyman
2020-01-04  0:58           ` Prashant Malani [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACeCKaeoPER7wmE7uj-R0a=8eRC64TpRcP0=bg=mvtx7h72DfQ@mail.gmail.com' \
    --to=pmalani@chromium.org \
    --cc=bernhard.gebetsberger@gmx.at \
    --cc=grundler@chromium.org \
    --cc=hayeswang@realtek.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).