From: Prashant Malani <pmalani@chromium.org>
To: Utkarsh Patel <utkarsh.h.patel@intel.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:USB NETWORKING DRIVERS" <linux-usb@vger.kernel.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Rajmohan Mani <rajmohan.mani@intel.com>,
Azhar Shaikh <azhar.shaikh@intel.com>
Subject: Re: [PATCH v2 5/8] usb: typec: Use Thunderbolt 3 cable discover mode VDO in Enter_USB message
Date: Tue, 17 Nov 2020 16:44:27 -0800 [thread overview]
Message-ID: <CACeCKaf6ErEdzcWAXU_1ES63za8GunFgWfOnhiJOowY3iYA6UQ@mail.gmail.com> (raw)
In-Reply-To: <20201117211619.GD1819103@google.com>
On Tue, Nov 17, 2020 at 1:16 PM Prashant Malani <pmalani@chromium.org> wrote:
>
> Hi Utkarsh,
>
> On Fri, Nov 13, 2020 at 12:25:00PM -0800, Utkarsh Patel wrote:
> > USB4 also uses same cable properties as Thunderbolt 3 so use Thunderbolt 3
> > cable discover mode VDO to fill details such as active cable plug link
> > training and cable rounded support.
On digging into the Cros EC code further, sounds like active cable
link training and cable rounded are necessarily only part of
cables that have a TBT cable VDO, so sounds like the approach in the
patch is fine.
Sorry for the noise.
Best regards,
-Prashant
next prev parent reply other threads:[~2020-11-18 0:45 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 20:24 [PATCH v2 0/8] Thunderbolt3/USB4 cable rounded and active cable plug link training support Utkarsh Patel
2020-11-13 20:24 ` [PATCH v2 1/8] usb: typec: Correct the bit values for the Thunderbolt rounded/non-rounded cable support Utkarsh Patel
2020-11-17 10:43 ` Heikki Krogerus
2020-11-13 20:24 ` [PATCH v2 2/8] platform/chrome: cros_ec_typec: Correct " Utkarsh Patel
2020-11-17 10:44 ` Heikki Krogerus
2020-11-17 10:49 ` Enric Balletbo i Serra
2020-11-13 20:24 ` [PATCH v2 3/8] usb: typec: intel_pmc_mux: Configure Thunderbolt cable generation bits Utkarsh Patel
2020-11-17 10:45 ` Heikki Krogerus
2020-11-13 20:24 ` [PATCH v2 4/8] usb: typec: Remove one bit support for the Thunderbolt rounded/non-rounded cable Utkarsh Patel
2020-11-17 10:46 ` Heikki Krogerus
2020-11-13 20:25 ` [PATCH v2 5/8] usb: typec: Use Thunderbolt 3 cable discover mode VDO in Enter_USB message Utkarsh Patel
2020-11-17 12:09 ` Heikki Krogerus
2020-11-17 23:28 ` Patel, Utkarsh H
2020-11-17 21:16 ` Prashant Malani
2020-11-18 0:44 ` Prashant Malani [this message]
2020-11-13 20:25 ` [PATCH v2 6/8] platform/chrome: cros_ec_typec: Use Thunderbolt 3 cable discover mode VDO in USB4 mode Utkarsh Patel
2020-11-17 10:49 ` Enric Balletbo i Serra
2020-11-17 12:10 ` Heikki Krogerus
2020-11-17 18:19 ` Prashant Malani
2020-11-18 1:06 ` Prashant Malani
2020-11-18 4:07 ` Patel, Utkarsh H
2020-11-13 20:25 ` [PATCH v2 7/8] usb: typec: intel_pmc_mux: Configure active cable properties for USB4 Utkarsh Patel
2020-11-17 12:21 ` Heikki Krogerus
2020-11-17 22:37 ` Patel, Utkarsh H
2020-11-13 20:25 ` [PATCH v2 8/8] usb: typec: Remove active_link_training variable from Enter_USB message Utkarsh Patel
2020-11-17 12:22 ` Heikki Krogerus
2020-11-18 11:54 ` [PATCH v2 0/8] Thunderbolt3/USB4 cable rounded and active cable plug link training support Greg KH
2020-11-18 22:02 ` Patel, Utkarsh H
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACeCKaf6ErEdzcWAXU_1ES63za8GunFgWfOnhiJOowY3iYA6UQ@mail.gmail.com \
--to=pmalani@chromium.org \
--cc=azhar.shaikh@intel.com \
--cc=enric.balletbo@collabora.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rajmohan.mani@intel.com \
--cc=utkarsh.h.patel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).