From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86DABC43603 for ; Thu, 12 Dec 2019 21:22:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5656A214AF for ; Thu, 12 Dec 2019 21:22:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="bM7p1YBo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731065AbfLLVWy (ORCPT ); Thu, 12 Dec 2019 16:22:54 -0500 Received: from mail-io1-f65.google.com ([209.85.166.65]:37759 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731032AbfLLVWy (ORCPT ); Thu, 12 Dec 2019 16:22:54 -0500 Received: by mail-io1-f65.google.com with SMTP id k24so183177ioc.4 for ; Thu, 12 Dec 2019 13:22:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rmJb/JSmwLP599MA6+95ChQfw+WGEE+74ZZ6eN1os3M=; b=bM7p1YBoVme4Z7buLu8zoz5ghlclJvqlRjXqPKOx0Df4yKB0aCJle4s2SoFuf/3+Sj 8ytbwFqRzQ+NRXKB4Yg0bn1vbK3fwEppKagnBuiy+N+NMF/WZint3qELtXP1OkHSPOTN 3yTUUVbtCw961MVV0qjMF05UNyZUBF9DP6L5A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rmJb/JSmwLP599MA6+95ChQfw+WGEE+74ZZ6eN1os3M=; b=c+zj4f24mHfraDcO2FTm8oRsnUemqFqY35Q1CGsxAfEfKaBUYim2e2ktwJXJjeEYyW 9ka1FrAt9FRqDAuxOqA1E/OJS14rlgSIduXh0gFvR9XGNwv+iejsjcwatkEyK8ZCMlvI W1njPVVLdPKtZsfNSKykEu2jG89MScukOA+aTFPc6DZ/0cWNxv2jqLRbIOZbfDzwKrQu gTRFnTvrkBILjy1JGBHjpbPUxRenGKETH00t2P3euSCR891MdyRU0QZXfgEz/fnG0k9M aZ6pMgqhCy9qTvVx+e7eLvPxOUKvnYJqM8G++AwIV+KvysccG3o/Yjhs5RWaEBAajk7n ag9w== X-Gm-Message-State: APjAAAX/7j/JKolDaf1YQbWblXtnU90qUzboSpax/7xvGMB0ZFqErlX1 ZlV5DYtB0+L6xlrYbmHm1F4BNJq8s7o= X-Google-Smtp-Source: APXvYqwecYnTRn1IwLLG609ox8iLTssm/H1ImJSSV+BSPZRzKgyzoakkOXgWTXAchwo7B6zkBGpiZQ== X-Received: by 2002:a02:6207:: with SMTP id d7mr10122791jac.5.1576185773782; Thu, 12 Dec 2019 13:22:53 -0800 (PST) Received: from mail-io1-f54.google.com (mail-io1-f54.google.com. [209.85.166.54]) by smtp.gmail.com with ESMTPSA id d8sm1521459iok.66.2019.12.12.13.22.53 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Dec 2019 13:22:53 -0800 (PST) Received: by mail-io1-f54.google.com with SMTP id f82so155249ioa.9 for ; Thu, 12 Dec 2019 13:22:53 -0800 (PST) X-Received: by 2002:a05:6638:6a6:: with SMTP id d6mr9964231jad.132.1576185772710; Thu, 12 Dec 2019 13:22:52 -0800 (PST) MIME-Version: 1.0 References: <1574940787-1004-1-git-send-email-sanm@codeaurora.org> <1574940787-1004-2-git-send-email-sanm@codeaurora.org> <0101016ef9fb5396-c1cefc2e-82fa-4828-94c0-c739cd4cd16f-000000@us-west-2.amazonses.com> In-Reply-To: <0101016ef9fb5396-c1cefc2e-82fa-4828-94c0-c739cd4cd16f-000000@us-west-2.amazonses.com> From: Doug Anderson Date: Thu, 12 Dec 2019 13:22:40 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/3] usb: dwc3: Add support for SC7180 SOC To: "Sandeep Maheswaram (Temp)" Cc: Andy Gross , Bjorn Andersson , Greg Kroah-Hartman , Rob Herring , Mark Rutland , Felipe Balbi , Stephen Boyd , linux-arm-msm , linux-usb@vger.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Hi, On Thu, Dec 12, 2019 at 4:00 AM Sandeep Maheswaram (Temp) wrote: > > Hi, > > On 12/12/2019 1:13 AM, Doug Anderson wrote: > > Hi, > > > > On Thu, Nov 28, 2019 at 3:35 AM Sandeep Maheswaram wrote: > >> Add compatible for SC7180 SOC in USB DWC3 driver > >> > >> Signed-off-by: Sandeep Maheswaram > >> --- > >> drivers/usb/dwc3/dwc3-qcom.c | 3 ++- > >> 1 file changed, 2 insertions(+), 1 deletion(-) > >> > >> diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c > >> index 261af9e..1df2372 100644 > >> --- a/drivers/usb/dwc3/dwc3-qcom.c > >> +++ b/drivers/usb/dwc3/dwc3-qcom.c > >> @@ -1,5 +1,5 @@ > >> // SPDX-License-Identifier: GPL-2.0 > >> -/* Copyright (c) 2018, The Linux Foundation. All rights reserved. > >> +/* Copyright (c) 2018-2019, The Linux Foundation. All rights reserved. > >> * > >> * Inspired by dwc3-of-simple.c > >> */ > >> @@ -753,6 +753,7 @@ static const struct of_device_id dwc3_qcom_of_match[] = { > >> { .compatible = "qcom,dwc3" }, > >> { .compatible = "qcom,msm8996-dwc3" }, > >> { .compatible = "qcom,msm8998-dwc3" }, > >> + { .compatible = "qcom,sc7180-dwc3" }, > >> { .compatible = "qcom,sdm845-dwc3" }, > > It is, of course, up to Felipe. ...but in my opinion this is the > > wrong change and instead we should be deleting the SoC-specific > > strings (msm8996, msm8998, sdm845) from this file because they don't > > buy us anything. To explain how it works: > > > > 1. Device tree should have both the "SoC-specific" and generic > > "qcom,dwc3" strings. Only the "qcom,dwc3" will actually be used but > > the SoC-specific string is there so if we find a case later where we > > need to handle a SoC-specific quirk then it'll already be there. > > > > 2. Bindings should have both the "SoC-specific" and generic > > "qcom,dwc3" strings. The binding is describing what's in the device > > tree. > > > > 3. Until we have a SoC-specific quirk to handle, we _don't_ need to > > add the SoC-specific string to the driver itself. > > > > > > -Doug > > > Can i remove this patch { .compatible = "qcom,sc7180-dwc3" }, in the > next version of this series ? Yeah, drop patch #1 from your series. I've helped you out and posted: https://lore.kernel.org/r/20191212132122.1.I85a23bdcff04dbce48cc46ddb8f1ffe7a51015eb@changeid -Doug