From: Stephen Boyd <swboyd@chromium.org>
To: Matthias Kaehlcke <mka@chromium.org>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Felipe Balbi <balbi@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mathias Nyman <mathias.nyman@intel.com>,
Rob Herring <robh+dt@kernel.org>,
Bastien Nocera <hadess@hadess.net>,
Krzysztof Kozlowski <krzk@kernel.org>,
Douglas Anderson <dianders@chromium.org>,
Peter Chen <peter.chen@kernel.org>,
Ravi Chandra Sadineni <ravisadineni@chromium.org>,
linux-usb@vger.kernel.org, Roger Quadros <rogerq@kernel.org>,
Michal Simek <michal.simek@xilinx.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v19 5/5] arm64: dts: qcom: sc7180-trogdor: Add nodes for onboard USB hub
Date: Wed, 12 Jan 2022 14:00:08 -0800 [thread overview]
Message-ID: <CAE-0n50TzwqM--3v7wOEP07f5x7Dk9zDayF8Q+O2MvXYWMaCBg@mail.gmail.com> (raw)
In-Reply-To: <Yd8/XdMuAVW0fM6e@google.com>
Quoting Matthias Kaehlcke (2022-01-12 12:51:41)
> On Wed, Jan 12, 2022 at 12:47:15PM -0800, Stephen Boyd wrote:
> > Quoting Matthias Kaehlcke (2022-01-12 11:10:48)
>
> > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> > > index d4f4441179fc..cd31460b3bd6 100644
> > > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> > > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> > > @@ -202,7 +202,6 @@ pp3300_hub: pp3300-hub {
> > > pinctrl-names = "default";
> > > pinctrl-0 = <&en_pp3300_hub>;
> > >
> > > - regulator-always-on;
> > > regulator-boot-on;
> >
> > Is regulator-boot-on necessary?
>
> It tells the kernel that the regulator is already on at boot, and avoids an
> off-on cycle that would happen otherwise (internal reference: b/185972336).
Got it! A comment here would be helpful so we know the BIOS leaves the
regulator on.
next prev parent reply other threads:[~2022-01-12 22:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-12 19:10 [PATCH v19 0/5] usb: misc: Add onboard_usb_hub driver Matthias Kaehlcke
2022-01-12 19:10 ` [PATCH v19 1/5] of/platform: Add stubs for of_platform_device_create/destroy() Matthias Kaehlcke
2022-01-12 22:01 ` Stephen Boyd
2022-01-13 1:02 ` Doug Anderson
2022-01-12 19:10 ` [PATCH v19 2/5] driver core: Export device_is_bound() Matthias Kaehlcke
2022-01-13 1:02 ` Doug Anderson
2022-01-13 3:49 ` Stephen Boyd
2022-01-12 19:10 ` [PATCH v19 3/5] usb: misc: Add onboard_usb_hub driver Matthias Kaehlcke
2022-01-13 1:02 ` Doug Anderson
2022-01-13 3:49 ` Stephen Boyd
2022-01-13 18:38 ` Matthias Kaehlcke
2022-01-12 19:10 ` [PATCH v19 4/5] usb: core: hcd: Create platform devices for onboard hubs in probe() Matthias Kaehlcke
2022-01-13 1:03 ` Doug Anderson
2022-01-13 3:50 ` Stephen Boyd
2022-01-12 19:10 ` [PATCH v19 5/5] arm64: dts: qcom: sc7180-trogdor: Add nodes for onboard USB hub Matthias Kaehlcke
2022-01-12 20:47 ` Stephen Boyd
2022-01-12 20:51 ` Matthias Kaehlcke
2022-01-12 22:00 ` Stephen Boyd [this message]
2022-01-13 1:03 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE-0n50TzwqM--3v7wOEP07f5x7Dk9zDayF8Q+O2MvXYWMaCBg@mail.gmail.com \
--to=swboyd@chromium.org \
--cc=agross@kernel.org \
--cc=balbi@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hadess@hadess.net \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=michal.simek@xilinx.com \
--cc=mka@chromium.org \
--cc=peter.chen@kernel.org \
--cc=ravisadineni@chromium.org \
--cc=robh+dt@kernel.org \
--cc=rogerq@kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).