From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BE34C433F5 for ; Wed, 12 Jan 2022 20:47:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1357725AbiALUrR (ORCPT ); Wed, 12 Jan 2022 15:47:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357719AbiALUrQ (ORCPT ); Wed, 12 Jan 2022 15:47:16 -0500 Received: from mail-ot1-x32f.google.com (mail-ot1-x32f.google.com [IPv6:2607:f8b0:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88780C06173F for ; Wed, 12 Jan 2022 12:47:16 -0800 (PST) Received: by mail-ot1-x32f.google.com with SMTP id m8-20020a9d4c88000000b00592bae7944bso779060otf.1 for ; Wed, 12 Jan 2022 12:47:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:in-reply-to:references:from:user-agent:date:message-id :subject:to:cc; bh=0uCoA9gtquAQnLHyAGMH5yVKo8Duifh87vN3LET60pI=; b=SnD1JKebqAjYC5/mV/x2NVj0fqVqMvELGDmhlzsqOrnOKrDhwpPSGP84I9xaHm2Rbq iGwHRKPGD+nQIsMfjP4tWbcBNbjEBV8aJhdGEWDHUfP0C+m2H19S1ux3ku8quhLV09vz 5DPxadd9dgWkIVpLgZ1tlCNyvk7npsNGMXYpI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:in-reply-to:references:from :user-agent:date:message-id:subject:to:cc; bh=0uCoA9gtquAQnLHyAGMH5yVKo8Duifh87vN3LET60pI=; b=7mixNDhswHQ2/dB5vuta2h+9lpIddwPDT6pPi4BOGzN7h+1mSHkvng3x8cLCeuzkUS YI212hYJpgvdGkbgOf6lBvTun779dADOkg88SNWeWuzMaKvCbdpKQT0LRsBfds0hM1Sb EZ7CpTD5kBW/YvM9hpruXx/2YfHy2vvsJkz/6Pk4/nRCMG5Wybub0E2mPxZ9iRiqKcom QsZ2I51T7ZVjcv1S6yvyBfPZOBMQDKfZ1cO0ceE094NkHf+IRMzfVe2XYbmlYoBQQxBP cTAkXspOTqX/5gNZtRkKHSS/fQi7KMRq1LTkMMoSHz+qXfagN/pnIHwwXwiplNMcozx1 mLAw== X-Gm-Message-State: AOAM5316qeRRcjcMNVlyysH2RU/zFFqZ+vTF8rpRQ+ni7y1DjwHtvfWa 5DIrBemGueA8YmMty5G6cuMqMx3lbAjFestev25IoA== X-Google-Smtp-Source: ABdhPJy9DmFUV/f3PVpJF83pL5khFYgu6zkYLCna4fPGNS9nED/DGpoKwj7OQP4IEupq54UmgFfYL6V0X/WXPaWBUDU= X-Received: by 2002:a9d:7451:: with SMTP id p17mr1054973otk.159.1642020435932; Wed, 12 Jan 2022 12:47:15 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 12 Jan 2022 12:47:15 -0800 MIME-Version: 1.0 In-Reply-To: <20220112111028.v19.5.Ie0d2c1214b767bb5551dd4cad38398bd40e4466f@changeid> References: <20220112191048.837236-1-mka@chromium.org> <20220112111028.v19.5.Ie0d2c1214b767bb5551dd4cad38398bd40e4466f@changeid> From: Stephen Boyd User-Agent: alot/0.9.1 Date: Wed, 12 Jan 2022 12:47:15 -0800 Message-ID: Subject: Re: [PATCH v19 5/5] arm64: dts: qcom: sc7180-trogdor: Add nodes for onboard USB hub To: Alan Stern , Felipe Balbi , Frank Rowand , Greg Kroah-Hartman , Mathias Nyman , Matthias Kaehlcke , Rob Herring Cc: Bastien Nocera , Krzysztof Kozlowski , Douglas Anderson , Peter Chen , Ravi Chandra Sadineni , linux-usb@vger.kernel.org, Roger Quadros , Michal Simek , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Andy Gross , Bjorn Andersson , linux-arm-msm@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Quoting Matthias Kaehlcke (2022-01-12 11:10:48) > Add nodes for the onboard USB hub on trogdor devices. Remove the > 'always-on' property from the hub regulator, since the regulator > is now managed by the onboard_usb_hub driver. > > Signed-off-by: Matthias Kaehlcke > --- One question below Reviewed-by: Stephen Boyd > > .../boot/dts/qcom/sc7180-trogdor-lazor-r0.dts | 19 ++++++++----------- > .../boot/dts/qcom/sc7180-trogdor-lazor-r1.dts | 12 +++++------- > .../dts/qcom/sc7180-trogdor-pompom-r1.dts | 11 ++++------- > .../arm64/boot/dts/qcom/sc7180-trogdor-r1.dts | 19 ++++++++----------- > arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 19 ++++++++++++++++++- > 5 files changed, 43 insertions(+), 37 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > index d4f4441179fc..cd31460b3bd6 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi > @@ -202,7 +202,6 @@ pp3300_hub: pp3300-hub { > pinctrl-names = "default"; > pinctrl-0 = <&en_pp3300_hub>; > > - regulator-always-on; > regulator-boot-on; Is regulator-boot-on necessary? > > vin-supply = <&pp3300_a>;