From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"marex@denx.de" <marex@denx.de>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH for-5.8 v2] usb: dwc2: Add missing cleanups when usb_add_gadget_udc() fails
Date: Mon, 27 Jul 2020 19:35:44 +0200 [thread overview]
Message-ID: <CAFBinCCzRF3XFMwDC7EhMYR=ydhbyYkXVSK7o6kuTg=7B_HngQ@mail.gmail.com> (raw)
In-Reply-To: <9de38c5f-6fdb-5fc0-3fd3-bec42b8807a2@synopsys.com>
Hello Minas,
On Sun, Jul 26, 2020 at 12:04 PM Minas Harutyunyan
<Minas.Harutyunyan@synopsys.com> wrote:
[...]
> Kernel test robot found issue:
> >> warning: unused label 'error_debugfs' [-Wunused-label]
> error_debugfs:
> ^~~~~~~~~~~~~~
> 1 warning generated.
>
> So, 'error_debugfs:' label should be under #if/#endif:
>
> #if IS_ENABLED(CONFIG_USB_DWC2_PERIPHERAL) || \
> IS_ENABLED(CONFIG_USB_DWC2_DUAL_ROLE)
> error_debugfs:
> #endif /* CONFIG_USB_DWC2_PERIPHERAL || CONFIG_USB_DWC2_DUAL_ROLE */
>
> Or you have other suggestion?
unfortunately I have no better idea
> Could you please fix this issue and submit new version of patch.
I'm going to cover everything I add inside the same #if (not just the
error label).
if any additional label is added (above) in the future then the code
that I'm adding must not be executed when that #if evaluates to false
v3 is coming in the next few minutes.
Best regards,
Martin
prev parent reply other threads:[~2020-07-27 17:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-03 22:50 [PATCH for-5.8 v2] usb: dwc2: Add missing cleanups when usb_add_gadget_udc() fails Martin Blumenstingl
2020-07-04 5:58 ` Minas Harutyunyan
2020-07-26 10:04 ` Minas Harutyunyan
2020-07-27 17:35 ` Martin Blumenstingl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFBinCCzRF3XFMwDC7EhMYR=ydhbyYkXVSK7o6kuTg=7B_HngQ@mail.gmail.com' \
--to=martin.blumenstingl@googlemail.com \
--cc=Minas.Harutyunyan@synopsys.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=marex@denx.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).