From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18B7FC0650E for ; Wed, 3 Jul 2019 09:01:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E34CA218A5 for ; Wed, 3 Jul 2019 09:01:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=googlemail.com header.i=@googlemail.com header.b="NBlReOsC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727212AbfGCJBX (ORCPT ); Wed, 3 Jul 2019 05:01:23 -0400 Received: from mail-ot1-f65.google.com ([209.85.210.65]:43404 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727197AbfGCJBW (ORCPT ); Wed, 3 Jul 2019 05:01:22 -0400 Received: by mail-ot1-f65.google.com with SMTP id q10so1538654otk.10; Wed, 03 Jul 2019 02:01:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Nqsl7mw8i2F0KpVu3YClsX9awvB+a3f/6kMjL+tSEX0=; b=NBlReOsCEysqP0tKzR7+2SoIMgPZQTbMxjMN3O689cupA+zJC9X7NQ9JzYy95V7Zth khffgZXpyEMVM9zQmRz9cELHlokp1YbTApLv0wpoXlMIcymKqHW183DDIzGRb/9w7Eds QDyARb5iMwDqaKh7m8vX0dkpF+XaJvTBDxFerSPzoZa0Gtnt0srZuDrTT9q6cBr45SCe F8ec5gQqYMTm0jd/rVyPy2xD96AkVQXxthY83d+xzkJoVG/W01+yvxMG1aIdjSopExuN VzXRIhGajp86xxbkNMiSKFJ6G0U3OS1Ncv5k71aGEdus+ltgEb7BfANujqZwT2nKNIeB tGjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Nqsl7mw8i2F0KpVu3YClsX9awvB+a3f/6kMjL+tSEX0=; b=tAGSAqRlQs/5dXLBvu1Sqcdh0LdjKBghXrIU4GfGy1TuernubL7xiXI0FYWUJBjyxd tCfm7PTulBd3arRNHaiSmBVXgLg4bRruZ9pTLSib9lvPlWKsdqjsd5hPKk4YmlK/A2lw 2VRrJZyIOZZPXNqc7JQsbyBCI3LAfFcVWkoQMdT0blc35ayRrD8B7Iy6MRM3hZraxliG b0QVNJhDQAhAOeuEuSsbwor4uj3daGqteRzKa1lbvNDVyYDv+b9DaqibiIXCeqfhOCYE Tho0HRRvgBoV9+tF4ObcMdxy31U5GwvcnY0Myh6wDS9ZmTNSJbDMcP1tQoxEkVj+6MDC dIiw== X-Gm-Message-State: APjAAAWR+iJCpQuJrURwkGfa6p0uV9G8zStj0iitkGu358ZrYt4MmhhG GOlgA5nfz/YFsvBR1LeYpnfiooRTczcLJP3/qSw= X-Google-Smtp-Source: APXvYqy8nQfsCP9N5UeSronAuP31jlfLFowq8I3R9eP1zf8A8FBjZ25PU/l0s1nJ98KQZ2Cjy6gP0Ktnt+omp6h1XMI= X-Received: by 2002:a9d:226c:: with SMTP id o99mr27126789ota.42.1562144481370; Wed, 03 Jul 2019 02:01:21 -0700 (PDT) MIME-Version: 1.0 References: <20190620175022.29348-1-martin.blumenstingl@googlemail.com> In-Reply-To: From: Martin Blumenstingl Date: Wed, 3 Jul 2019 11:01:10 +0200 Message-ID: Subject: Re: [PATCH] usb: dwc2: use a longer AHB idle timeout in dwc2_core_reset() To: "felipe.balbi@linux.intel.com" Cc: "linux-usb@vger.kernel.org" , Minas Harutyunyan , "linux-kernel@vger.kernel.org" , linux-stable , "gregkh@linuxfoundation.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Mon, Jul 1, 2019 at 7:54 PM Martin Blumenstingl wrote: > > On Mon, Jun 24, 2019 at 7:41 AM Minas Harutyunyan > wrote: > > > > On 6/20/2019 9:51 PM, Martin Blumenstingl wrote: > > > Use a 10000us AHB idle timeout in dwc2_core_reset() and make it > > > consistent with the other "wait for AHB master IDLE state" ocurrences. > > > > > > This fixes a problem for me where dwc2 would not want to initialize when > > > updating to 4.19 on a MIPS Lantiq VRX200 SoC. dwc2 worked fine with > > > 4.14. > > > Testing on my board shows that it takes 180us until AHB master IDLE > > > state is signalled. The very old vendor driver for this SoC (ifxhcd) > > > used a 1 second timeout. > > > Use the same timeout that is used everywhere when polling for > > > GRSTCTL_AHBIDLE instead of using a timeout that "works for one board" > > > (180us in my case) to have consistent behavior across the dwc2 driver. > > > > > > Cc: linux-stable # 4.19+ > > > Signed-off-by: Martin Blumenstingl > > > --- > > > > Acked-by: Minas Harutyunyan > thank you for reviewing this! > > is there any chance we can get this fix into Linux 5.3? I know that > it's too late for 5.2 so I'm fine with skipping that. thank you Felipe for queuing this for v5.3! for reference, this patch is now in the usb-for-v5.3-part2 tag: [0] [0] https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git/commit/?h=usb-for-v5.3-part2&id=dfc4fdebc5d62ac4e2fe5428e59b273675515fb2