From: Ross Zwisler <zwisler@google.com>
To: Mathias Nyman <mathias.nyman@linux.intel.com>
Cc: Sergei Shtylyov <sergei.shtylyov@gmail.com>,
David Laight <David.Laight@aculab.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH 1/2] xhci: make sure TRB is fully written before giving it to the controller
Date: Tue, 19 Jan 2021 16:25:32 -0700 [thread overview]
Message-ID: <CAGRrVHxvhUyc=z1W13QUJJ8pJgscTJSLGgjV=1OmOKi0F16uqw@mail.gmail.com> (raw)
In-Reply-To: <2722043c-208b-c965-e6cf-8474c698df2c@linux.intel.com>
On Mon, Jan 18, 2021 at 5:05 AM Mathias Nyman
<mathias.nyman@linux.intel.com> wrote:
<>
> True, good point, dma_wmb() should be enough here.
> In fact most other wmb()s in xhci could be turned into dma_wmb().
FWIW I've confirmed in my testing that dma_wmb() does indeed also
solve the problem.
next prev parent reply other threads:[~2021-01-19 23:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 16:19 [PATCH 0/2] xhci fixes for usb-linus Mathias Nyman
2021-01-15 16:19 ` [PATCH 1/2] xhci: make sure TRB is fully written before giving it to the controller Mathias Nyman
2021-01-15 16:40 ` Sergei Shtylyov
2021-01-15 16:50 ` David Laight
2021-01-15 17:21 ` Sergei Shtylyov
2021-01-18 12:07 ` Mathias Nyman
2021-01-19 23:25 ` Ross Zwisler [this message]
2021-01-15 16:19 ` [PATCH 2/2] xhci: tegra: Delay for disabling LFPS detector Mathias Nyman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGRrVHxvhUyc=z1W13QUJJ8pJgscTJSLGgjV=1OmOKi0F16uqw@mail.gmail.com' \
--to=zwisler@google.com \
--cc=David.Laight@aculab.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=sergei.shtylyov@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).